* [PATCH v1] x86: acpi: Drop _HID() where enumerated by _ADR()
@ 2020-05-26 18:19 Andy Shevchenko
2020-05-27 14:16 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-05-26 18:19 UTC (permalink / raw)
To: u-boot
ACPICA complains that either _HID() or _ADR() should be used.
For General Purpose DMA we may not drop the _ADR() because
the device is enumerated by PCI. Thus, simple drop _HID().
Reported-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index eaf75c8c673d..01077293bb91 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -531,7 +531,6 @@ Device (PCI0)
Device (GDMA)
{
Name (_ADR, 0x00150000)
- Name (_HID, "808611A2")
Name (_UID, Zero)
Method (_STA, 0, NotSerialized)
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH v1] x86: acpi: Drop _HID() where enumerated by _ADR()
2020-05-26 18:19 [PATCH v1] x86: acpi: Drop _HID() where enumerated by _ADR() Andy Shevchenko
@ 2020-05-27 14:16 ` Andy Shevchenko
2020-05-28 0:51 ` Bin Meng
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-05-27 14:16 UTC (permalink / raw)
To: u-boot
On Tue, May 26, 2020 at 09:19:49PM +0300, Andy Shevchenko wrote:
> ACPICA complains that either _HID() or _ADR() should be used.
> For General Purpose DMA we may not drop the _ADR() because
> the device is enumerated by PCI. Thus, simple drop _HID().
Bin, since now all issues you found, being addressed, care to apply before
v2020.07 release?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1] x86: acpi: Drop _HID() where enumerated by _ADR()
2020-05-27 14:16 ` Andy Shevchenko
@ 2020-05-28 0:51 ` Bin Meng
0 siblings, 0 replies; 3+ messages in thread
From: Bin Meng @ 2020-05-28 0:51 UTC (permalink / raw)
To: u-boot
Hi Andy,
On Wed, May 27, 2020 at 10:16 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, May 26, 2020 at 09:19:49PM +0300, Andy Shevchenko wrote:
> > ACPICA complains that either _HID() or _ADR() should be used.
> > For General Purpose DMA we may not drop the _ADR() because
> > the device is enumerated by PCI. Thus, simple drop _HID().
>
> Bin, since now all issues you found, being addressed, care to apply before
> v2020.07 release?
>
Yes, this is planned in the next PR.
Regards,
Bin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-28 0:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-26 18:19 [PATCH v1] x86: acpi: Drop _HID() where enumerated by _ADR() Andy Shevchenko
2020-05-27 14:16 ` Andy Shevchenko
2020-05-28 0:51 ` Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox