[PATCH] cmd: fitupd: move config check to Kconfig

[PATCH] cmd: fitupd: move config check to Kconfig

[Heinrich Schuchardt]

Configuration checks should not be in the C files but in the Kconfig files.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
@Lukasz, @Tom
No board seems to be using the 'fitupd' command anymore. Shouldn't we
simply remove it? 'dfu tftp' offers a similar functionality.

Best regards

Heinrich
---
 cmd/Kconfig  | 1 +
 cmd/fitupd.c | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 153864c587..192b3b262f 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -491,6 +491,7 @@ config CMD_SPL_WRITE_SIZE

 config CMD_FITUPD
 	bool "fitImage update command"
+	depends on UPDATE_TFTP
 	help
 	  Implements the 'fitupd' command, which allows to automatically
 	  store software updates present on a TFTP server in NOR Flash
diff --git a/cmd/fitupd.c b/cmd/fitupd.c
index f6270d9c15..0f490c58fc 100644
--- a/cmd/fitupd.c
+++ b/cmd/fitupd.c
@@ -8,10 +8,6 @@
 #include <command.h>
 #include <net.h>

-#if !defined(CONFIG_UPDATE_TFTP)
-#error "CONFIG_UPDATE_TFTP required"
-#endif
-
 static int do_fitupd(struct cmd_tbl *cmdtp, int flag, int argc,
 		     char *const argv[])
 {
--
2.26.2

[PATCH] cmd: fitupd: move config check to Kconfig

[Tom Rini]

On Tue, May 26, 2020 at 06:34:15PM +0200, Heinrich Schuchardt wrote:

> Configuration checks should not be in the C files but in the Kconfig files.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

For the patch itself:

Reviewed-by: Tom Rini <trini@konsulko.com>

> ---
> @Lukasz, @Tom
> No board seems to be using the 'fitupd' command anymore. Shouldn't we
> simply remove it? 'dfu tftp' offers a similar functionality.

So yes, DFU over TFTP came later and leverages the minor updates the
series that added fitupd command did.  It's also never been enabled by
default anywhere.  Perhaps we should just enable it for sandbox?  It's
small enough that it's probably useful in out of tree configs.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200526/f4567629/attachment.sig>

[PATCH] cmd: fitupd: move config check to Kconfig

[Lukasz Majewski]

Hi Heinrich,

> Configuration checks should not be in the C files but in the Kconfig
> files.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> @Lukasz, @Tom
> No board seems to be using the 'fitupd' command anymore. Shouldn't we
> simply remove it? 'dfu tftp' offers a similar functionality.

We can plan to remove it after the current release (as we are now with
-rc3).

> 
> Best regards
> 
> Heinrich
> ---
>  cmd/Kconfig  | 1 +
>  cmd/fitupd.c | 4 ----
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 153864c587..192b3b262f 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -491,6 +491,7 @@ config CMD_SPL_WRITE_SIZE
> 
>  config CMD_FITUPD
>  	bool "fitImage update command"
> +	depends on UPDATE_TFTP
>  	help
>  	  Implements the 'fitupd' command, which allows to
> automatically store software updates present on a TFTP server in NOR
> Flash diff --git a/cmd/fitupd.c b/cmd/fitupd.c
> index f6270d9c15..0f490c58fc 100644
> --- a/cmd/fitupd.c
> +++ b/cmd/fitupd.c
> @@ -8,10 +8,6 @@
>  #include <command.h>
>  #include <net.h>
> 
> -#if !defined(CONFIG_UPDATE_TFTP)
> -#error "CONFIG_UPDATE_TFTP required"
> -#endif
> -
>  static int do_fitupd(struct cmd_tbl *cmdtp, int flag, int argc,
>  		     char *const argv[])
>  {
> --
> 2.26.2
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200527/3d179ffd/attachment.sig>

[PATCH] cmd: fitupd: move config check to Kconfig

[Tom Rini]

On Tue, May 26, 2020 at 06:34:15PM +0200, Heinrich Schuchardt wrote:

> Configuration checks should not be in the C files but in the Kconfig files.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/807b69b3/attachment.sig>