[PATCH 08/24] arm: Remove configs/P1020MBG-PC_36BIT_SDCARD_defconfig board

Simon Glass
2020-05-28T20:32:39Z

Hi,

On Thu, 28 May 2020 at 14:15, Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, May 28, 2020 at 07:07:14AM +0000, Priyanka Jain wrote:
> > >-----Original Message-----
> > >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Jagan Teki
> > >Sent: Wednesday, May 27, 2020 10:17 PM
> > >To: Simon Glass <sjg@chromium.org>; Tom Rini <trini@konsulko.com>
> > >Cc: u-boot at lists.denx.de; linux-amarula at amarulasolutions.com; Jagan Teki
> > ><jagan@amarulasolutions.com>
> > >Subject: [PATCH 08/24] arm: Remove configs/P1020MBG-
> > >PC_36BIT_SDCARD_defconfig board
> > >
> > >This board has not been converted to CONFIG_DM_SPI by the deadline.
> > >
> > >Remove it.
> > >
> > >Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > >---
> > > arch/powerpc/cpu/mpc85xx/Kconfig | 1 -
> > > board/freescale/p1_p2_rdb_pc/Kconfig | 19 -
> > > board/freescale/p1_p2_rdb_pc/MAINTAINERS | 51 --
> > > board/freescale/p1_p2_rdb_pc/Makefile | 24 -
> > > board/freescale/p1_p2_rdb_pc/README | 66 --
> > > board/freescale/p1_p2_rdb_pc/ddr.c | 292 ------
> > > board/freescale/p1_p2_rdb_pc/law.c | 22 -
> > > board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 536 -----------
> > > board/freescale/p1_p2_rdb_pc/spl.c | 123 ---
> > > board/freescale/p1_p2_rdb_pc/spl_minimal.c | 63 --
> > > board/freescale/p1_p2_rdb_pc/tlb.c | 110 ---
> > > configs/P1020MBG-PC_36BIT_SDCARD_defconfig | 67 --
> > > configs/P1020MBG-PC_36BIT_defconfig | 55 --
> > > configs/P1020MBG-PC_SDCARD_defconfig | 66 --
> > > configs/P1020MBG-PC_defconfig | 54 --
> > > configs/P1020RDB-PC_36BIT_NAND_defconfig | 85 --
> > > configs/P1020RDB-PC_36BIT_SDCARD_defconfig | 80 --
> > > configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig | 82 --
> > > configs/P1020RDB-PC_36BIT_defconfig | 69 --
> > > configs/P1020RDB-PC_NAND_defconfig | 84 --
> > > configs/P1020RDB-PC_SDCARD_defconfig | 79 --
> > > configs/P1020RDB-PC_SPIFLASH_defconfig | 81 --
> > > configs/P1020RDB-PC_defconfig | 68 --
> > > configs/P1020RDB-PD_NAND_defconfig | 88 --
> > > configs/P1020RDB-PD_SDCARD_defconfig | 83 --
> > > configs/P1020RDB-PD_SPIFLASH_defconfig | 85 --
> > > configs/P1020RDB-PD_defconfig | 72 --
> > > configs/P1020UTM-PC_36BIT_SDCARD_defconfig | 67 --
> > > configs/P1020UTM-PC_36BIT_defconfig | 55 --
> > > configs/P1020UTM-PC_SDCARD_defconfig | 66 --
> > > configs/P1020UTM-PC_defconfig | 54 --
> > > configs/P1021RDB-PC_36BIT_NAND_defconfig | 84 --
> > > configs/P1021RDB-PC_36BIT_SDCARD_defconfig | 79 --
> > > configs/P1021RDB-PC_36BIT_SPIFLASH_defconfig | 81 --
> > > configs/P1021RDB-PC_36BIT_defconfig | 67 --
> > > configs/P1021RDB-PC_NAND_defconfig | 83 --
> > > configs/P1021RDB-PC_SDCARD_defconfig | 78 --
> > > configs/P1021RDB-PC_SPIFLASH_defconfig | 80 --
> > > configs/P1021RDB-PC_defconfig | 66 --
> > > configs/P1024RDB_36BIT_defconfig | 61 --
> > > configs/P1024RDB_NAND_defconfig | 77 --
> > > configs/P1024RDB_SDCARD_defconfig | 71 --
> > > configs/P1024RDB_SPIFLASH_defconfig | 73 --
> > > configs/P1024RDB_defconfig | 60 --
> > > configs/P1025RDB_36BIT_defconfig | 63 --
> > > configs/P1025RDB_NAND_defconfig | 80 --
> > > configs/P1025RDB_SDCARD_defconfig | 73 --
> > > configs/P1025RDB_SPIFLASH_defconfig | 76 --
> > > configs/P1025RDB_defconfig | 62 --
> > > configs/P2020RDB-PC_36BIT_NAND_defconfig | 90 --
> > > configs/P2020RDB-PC_36BIT_SDCARD_defconfig | 85 --
> > > configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig | 87 --
> > > configs/P2020RDB-PC_36BIT_defconfig | 74 --
> > > configs/P2020RDB-PC_NAND_defconfig | 89 --
> > > configs/P2020RDB-PC_SDCARD_defconfig | 84 --
> > > configs/P2020RDB-PC_SPIFLASH_defconfig | 86 --
> > > configs/P2020RDB-PC_defconfig | 73 --
> > > include/configs/p1_p2_rdb_pc.h | 881 -------------------
> > > 58 files changed, 5610 deletions(-)
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/Kconfig
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/MAINTAINERS
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/Makefile
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/README
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/ddr.c
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/law.c
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/spl.c
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/spl_minimal.c
> > > delete mode 100644 board/freescale/p1_p2_rdb_pc/tlb.c
> > > delete mode 100644 configs/P1020MBG-PC_36BIT_SDCARD_defconfig
> > > delete mode 100644 configs/P1020MBG-PC_36BIT_defconfig
> > > delete mode 100644 configs/P1020MBG-PC_SDCARD_defconfig
> > > delete mode 100644 configs/P1020MBG-PC_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_36BIT_NAND_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_36BIT_SDCARD_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_36BIT_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_NAND_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_SDCARD_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_SPIFLASH_defconfig
> > > delete mode 100644 configs/P1020RDB-PC_defconfig
> > > delete mode 100644 configs/P1020RDB-PD_NAND_defconfig
> > > delete mode 100644 configs/P1020RDB-PD_SDCARD_defconfig
> > > delete mode 100644 configs/P1020RDB-PD_SPIFLASH_defconfig
> > > delete mode 100644 configs/P1020RDB-PD_defconfig
> > > delete mode 100644 configs/P1020UTM-PC_36BIT_SDCARD_defconfig
> > > delete mode 100644 configs/P1020UTM-PC_36BIT_defconfig
> > > delete mode 100644 configs/P1020UTM-PC_SDCARD_defconfig
> > > delete mode 100644 configs/P1020UTM-PC_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_36BIT_NAND_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_36BIT_SDCARD_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_36BIT_SPIFLASH_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_36BIT_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_NAND_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_SDCARD_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_SPIFLASH_defconfig
> > > delete mode 100644 configs/P1021RDB-PC_defconfig
> > > delete mode 100644 configs/P1024RDB_36BIT_defconfig
> > > delete mode 100644 configs/P1024RDB_NAND_defconfig
> > > delete mode 100644 configs/P1024RDB_SDCARD_defconfig
> > > delete mode 100644 configs/P1024RDB_SPIFLASH_defconfig
> > > delete mode 100644 configs/P1024RDB_defconfig
> > > delete mode 100644 configs/P1025RDB_36BIT_defconfig
> > > delete mode 100644 configs/P1025RDB_NAND_defconfig
> > > delete mode 100644 configs/P1025RDB_SDCARD_defconfig
> > > delete mode 100644 configs/P1025RDB_SPIFLASH_defconfig
> > > delete mode 100644 configs/P1025RDB_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_36BIT_NAND_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_36BIT_SDCARD_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_36BIT_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_NAND_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_SDCARD_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_SPIFLASH_defconfig
> > > delete mode 100644 configs/P2020RDB-PC_defconfig
> > > delete mode 100644 include/configs/p1_p2_rdb_pc.h
> > >
> > <snip>
> > NXP plans to keep maintaining these boards. Please don't merge this patch .
> >
> > The espi series of patches for DM migration were in review since long, but could not be merged because of dependency.
> > NXP engineers are working on rebasing the DM espi migration series.
> >
> > http://patchwork.ozlabs.org/project/uboot/list/?series=127282&state=*
> > http://patchwork.ozlabs.org/project/uboot/list/?series=138873
>
> Of this series, P1020MBG-PC_SDCARD, P1020UTM-PC_SDCARD,
> P1021RDB-PC_36BIT_SDCARD, P1021RDB-PC_SDCARD, P1024RDB_SDCARD,
> P1025RDB_SDCARD
> and also sometimes:
> +(P1021RDB-PC_36BIT_SDCARD) This board does not use CONFIG_DM_USB. Please update
> +(P1021RDB-PC_36BIT_SDCARD) the board to use CONFIG_DM_USB before the v2019.07 release.
> +(P1021RDB-PC_36BIT_SDCARD) This board does use CONFIG_LIBATA but has CONFIG_AHCI not
> +(P1021RDB-PC_36BIT_SDCARD) enabled. Please update the storage controller driver to use
> +(P1021RDB-PC_36BIT_SDCARD) CONFIG_AHCI before the v2019.07 release.
> or:
> +(P1021RDB-PC_SDCARD) This board does not use CONFIG_DM_PCI Please update
> +(P1021RDB-PC_SDCARD) the board to use CONFIG_DM_PCI before the v2019.07 release.
>
> And of course those non-MMC issues show up on other configs of the
> family. How far along are the plans to address those? Thanks!

I think it might be best to re-introduce the board later when it is
ready, since we are so far past the migration deadline. That will
unblock the SPI patches, which after all we want to get in to this
release or at least the next merge window.

Or perhaps just disable SPI flash, etc. for the board?

Regards,
Simon