From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH 3/3] x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge
Date: Mon, 1 Jun 2020 11:42:41 +0300 [thread overview]
Message-ID: <20200601084241.GC1634618@smile.fi.intel.com> (raw)
In-Reply-To: <1590984915-21854-3-git-send-email-bmeng.cn@gmail.com>
On Sun, May 31, 2020 at 09:15:15PM -0700, Bin Meng wrote:
> PCI Firmware specification requires _UID() and doesn't require _ADR()
> to be set. Replace latter by former. This fixes the following warning
> reported by ACPICA 20200430:
>
> Warning 3073 - Multiple types (Device object requires either a _HID
> or _ADR, but not both)
>
For all three:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> index fe9edc1..384dab2 100644
> --- a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> +++ b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> @@ -8,7 +8,7 @@ Device (PCI0)
> Name(_HID, EISAID("PNP0A08")) /* PCIe */
> Name(_CID, EISAID("PNP0A03")) /* PCI */
>
> - Name(_ADR, 0)
> + Name(_UID, 0)
> Name(_BBN, 0)
>
> Name(MCRS, ResourceTemplate()
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-06-01 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 4:15 [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
2020-06-01 4:15 ` [PATCH 2/3] x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge Bin Meng
2020-06-02 1:18 ` Bin Meng
2020-06-01 4:15 ` [PATCH 3/3] x86: quark: " Bin Meng
2020-06-01 8:42 ` Andy Shevchenko [this message]
2020-06-02 1:18 ` Bin Meng
2020-06-02 1:18 ` [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601084241.GC1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox