* [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods
@ 2020-06-01 4:15 Bin Meng
2020-06-01 4:15 ` [PATCH 2/3] x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge Bin Meng
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Bin Meng @ 2020-06-01 4:15 UTC (permalink / raw)
To: u-boot
Create buffers outside of the methods as ACPICA 20200430 complains
about this:
Remark 2173 - Creation of named objects within a method is highly
inefficient, use globals or method local variables instead
(\_SB.PCI0.LPCB.IURT._CRS)
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl b/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl
index 08b2f53..69455d9 100644
--- a/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl
+++ b/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl
@@ -136,20 +136,20 @@ Device (LPCB)
Store(0, C1EN)
}
- Method(_CRS, 0, Serialized)
+ Name(BUF0, ResourceTemplate()
{
- Name(BUF0, ResourceTemplate()
- {
- IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
- IRQNoFlags() { 3 }
- })
-
- Name(BUF1, ResourceTemplate()
- {
- IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
- IRQNoFlags() { 4 }
- })
+ IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
+ IRQNoFlags() { 3 }
+ })
+ Name(BUF1, ResourceTemplate()
+ {
+ IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
+ IRQNoFlags() { 4 }
+ })
+
+ Method(_CRS, 0, Serialized)
+ {
If (LLessEqual(SRID, 0x04)) {
Return (BUF0)
} Else {
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge
2020-06-01 4:15 [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
@ 2020-06-01 4:15 ` Bin Meng
2020-06-02 1:18 ` Bin Meng
2020-06-01 4:15 ` [PATCH 3/3] x86: quark: " Bin Meng
2020-06-02 1:18 ` [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
2 siblings, 1 reply; 7+ messages in thread
From: Bin Meng @ 2020-06-01 4:15 UTC (permalink / raw)
To: u-boot
PCI Firmware specification requires _UID() and doesn't require _ADR()
to be set. Replace latter by former. This fixes the following warning
reported by ACPICA 20200430:
Warning 3073 - Multiple types (Device object requires either a _HID
or _ADR, but not both)
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl b/arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl
index 2a1c31c..3b220c7 100644
--- a/arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl
@@ -11,7 +11,7 @@ Device (PCI0)
Name(_HID, EISAID("PNP0A08")) /* PCIe */
Name(_CID, EISAID("PNP0A03")) /* PCI */
- Name(_ADR, 0)
+ Name(_UID, 0)
Name(_BBN, 0)
Name(MCRS, ResourceTemplate()
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge
2020-06-01 4:15 [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
2020-06-01 4:15 ` [PATCH 2/3] x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge Bin Meng
@ 2020-06-01 4:15 ` Bin Meng
2020-06-01 8:42 ` Andy Shevchenko
2020-06-02 1:18 ` [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
2 siblings, 1 reply; 7+ messages in thread
From: Bin Meng @ 2020-06-01 4:15 UTC (permalink / raw)
To: u-boot
PCI Firmware specification requires _UID() and doesn't require _ADR()
to be set. Replace latter by former. This fixes the following warning
reported by ACPICA 20200430:
Warning 3073 - Multiple types (Device object requires either a _HID
or _ADR, but not both)
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
index fe9edc1..384dab2 100644
--- a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
@@ -8,7 +8,7 @@ Device (PCI0)
Name(_HID, EISAID("PNP0A08")) /* PCIe */
Name(_CID, EISAID("PNP0A03")) /* PCI */
- Name(_ADR, 0)
+ Name(_UID, 0)
Name(_BBN, 0)
Name(MCRS, ResourceTemplate()
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge
2020-06-01 4:15 ` [PATCH 3/3] x86: quark: " Bin Meng
@ 2020-06-01 8:42 ` Andy Shevchenko
2020-06-02 1:18 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2020-06-01 8:42 UTC (permalink / raw)
To: u-boot
On Sun, May 31, 2020 at 09:15:15PM -0700, Bin Meng wrote:
> PCI Firmware specification requires _UID() and doesn't require _ADR()
> to be set. Replace latter by former. This fixes the following warning
> reported by ACPICA 20200430:
>
> Warning 3073 - Multiple types (Device object requires either a _HID
> or _ADR, but not both)
>
For all three:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> index fe9edc1..384dab2 100644
> --- a/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> +++ b/arch/x86/include/asm/arch-quark/acpi/southcluster.asl
> @@ -8,7 +8,7 @@ Device (PCI0)
> Name(_HID, EISAID("PNP0A08")) /* PCIe */
> Name(_CID, EISAID("PNP0A03")) /* PCI */
>
> - Name(_ADR, 0)
> + Name(_UID, 0)
> Name(_BBN, 0)
>
> Name(MCRS, ResourceTemplate()
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 3/3] x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge
2020-06-01 8:42 ` Andy Shevchenko
@ 2020-06-02 1:18 ` Bin Meng
0 siblings, 0 replies; 7+ messages in thread
From: Bin Meng @ 2020-06-02 1:18 UTC (permalink / raw)
To: u-boot
On Mon, Jun 1, 2020 at 4:42 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Sun, May 31, 2020 at 09:15:15PM -0700, Bin Meng wrote:
> > PCI Firmware specification requires _UID() and doesn't require _ADR()
> > to be set. Replace latter by former. This fixes the following warning
> > reported by ACPICA 20200430:
> >
> > Warning 3073 - Multiple types (Device object requires either a _HID
> > or _ADR, but not both)
> >
>
> For all three:
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> > arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods
2020-06-01 4:15 [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
2020-06-01 4:15 ` [PATCH 2/3] x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge Bin Meng
2020-06-01 4:15 ` [PATCH 3/3] x86: quark: " Bin Meng
@ 2020-06-02 1:18 ` Bin Meng
2 siblings, 0 replies; 7+ messages in thread
From: Bin Meng @ 2020-06-02 1:18 UTC (permalink / raw)
To: u-boot
On Mon, Jun 1, 2020 at 12:15 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Create buffers outside of the methods as ACPICA 20200430 complains
> about this:
>
> Remark 2173 - Creation of named objects within a method is highly
> inefficient, use globals or method local variables instead
> (\_SB.PCI0.LPCB.IURT._CRS)
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-06-02 1:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-01 4:15 [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
2020-06-01 4:15 ` [PATCH 2/3] x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge Bin Meng
2020-06-02 1:18 ` Bin Meng
2020-06-01 4:15 ` [PATCH 3/3] x86: quark: " Bin Meng
2020-06-01 8:42 ` Andy Shevchenko
2020-06-02 1:18 ` Bin Meng
2020-06-02 1:18 ` [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox