[PATCH 08/13] test/py: efi_secboot: remove all "re.search"

Heinrich Schuchardt
2020-06-02T08:27:57Z

On 02.06.20 07:58, AKASHI Takahiro wrote:
> On Sat, May 30, 2020 at 09:04:11AM +0200, Heinrich Schuchardt wrote:
>> On 5/29/20 8:41 AM, AKASHI Takahiro wrote:
>>> Currently, we don't use any regular expression in matching outputs from
>>> U-Boot. Since its use is just redundant, we can remove all.
>>>
>>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>>
>> Applying: test/py: efi_secboot: remove all "re.search"
>> error: patch failed: test/py/tests/test_efi_secboot/test_signed.py:32
>> error: test/py/tests/test_efi_secboot/test_signed.py: patch does not apply
>> error: patch failed: test/py/tests/test_efi_secboot/test_unsigned.py:33
>> error: test/py/tests/test_efi_secboot/test_unsigned.py: patch does not apply
>> Patch failed at 0001 test/py: efi_secboot: remove all "re.search"
>>
>> Could you, please, rebase your patches.
>
> Probably due to the commit,
> ===
> commit 5827c2545849
> Author: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Date: Mon May 4 12:21:51 2020 +0200
>
> test: stabilize test_efi_secboot
> ===
>
> I have already proposed to revert this patch in
> https://lists.denx.de/pipermail/u-boot/2020-May/412859.html
>
> Anyway,
> the essential issue is not my test, but efi_console which
> tries to unconditionally send control code which a terminal may not
> understand.

When working via the serial console I am not aware of any other
possibility to discover the screen size which is needed for correct
scrolling.

The relevant specification is ECMA-48 with the following chapters:

8.3.14 CPR - ACTIVE POSITION REPORT
8.3.21 CUP - CURSOR POSITION
8.3.35 DSR - DEVICE STATUS REPORT

The other escape sequences used are described in the Linux man page
console_codes.4
(https://www.man7.org/linux/man-pages/man4/console_codes.4.html).

As long as you use a Linux console or xterm or a VT100 compatible
terminal you can expect the control codes to work.

If the environment variable stdout has the value "vidconsole", the
escape sequences are not issued.

We need a solution for the Python tests that will not break Gitlab CI
and Travis CI.

Best regards

Heinrich