From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1 1/2] net: cortina_ni: Addd eth support for Cortina Access CAxxxx SoCs
Date: Tue, 2 Jun 2020 09:02:17 -0400 [thread overview]
Message-ID: <20200602130217.GB21630@bill-the-cat> (raw)
In-Reply-To: <1591065866-5818-1-git-send-email-alex.nemirovsky@cortina-access.com>
On Mon, Jun 01, 2020 at 07:44:25PM -0700, Alex Nemirovsky wrote:
> From: Aaron Tseng <aaron.tseng@cortina-access.com>
>
> Add Cortina Access Ethernet device driver for CAxxxx SoCs.
> This driver supports both legacy and DM_ETH network models.
>
> Signed-off-by: Aaron Tseng <aaron.tseng@cortina-access.com>
> Signed-off-by: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>
>
> CC: Joe Hershberger <joe.hershberger@ni.com>
> CC: Abbie Chang <abbie.chang@Cortina-Access.com>
> CC: Tom Rini <trini@konsulko.com>
[snip]
> +#define HEADER_A_SIZE 8
> +#define CORTINA_NI_DBG 1
> +/*define CORTINA_NI_DBG if individual rx,tx,init needs to be called */
We have pr_debug, etc, please use those and not a custom debug defiine.
> +#ifdef CONFIG_DM_ETH
> +#if CORTINA_NI_DBG
> +static struct udevice *dbg_dev;
> +#endif
> +static struct udevice *curr_dev;
> +#else
The deadline for drivers to convert to DM for ethernet is v2020.07.
Please rework to not introduce any legacy mode support. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200602/7601f186/attachment.sig>
next prev parent reply other threads:[~2020-06-02 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 2:44 [PATCH v1 1/2] net: cortina_ni: Addd eth support for Cortina Access CAxxxx SoCs Alex Nemirovsky
2020-06-02 2:44 ` [PATCH v1 2/2] board: presidio-asic: Add CAxxxx Ethernet support Alex Nemirovsky
2020-06-02 13:02 ` Tom Rini [this message]
2020-06-03 0:18 ` [PATCH v1 1/2] net: cortina_ni: Addd eth support for Cortina Access CAxxxx SoCs Alex Nemirovsky
2020-06-03 0:38 ` Tom Rini
2020-06-03 1:35 ` Alex Nemirovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602130217.GB21630@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox