public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] cmd: part: Add 'block' sub-command
Date: Tue, 2 Jun 2020 13:55:56 -0400	[thread overview]
Message-ID: <20200602175556.GP21630@bill-the-cat> (raw)
In-Reply-To: <20200601102026.51707-2-razvan.becheriu@gmail.com>

On Mon, Jun 01, 2020 at 01:20:26PM +0300, razvan.becheriu at gmail.com wrote:
> From: Razvan Becheriu <razvan.becheriu@gmail.com>
> 
>     Add part block sub-command which returns block size.
> 
>     e.g.:
>      part block mmc $mmcdev system_a system_a_index
> 
> Signed-off-by: Razvan Becheriu <razvan.becheriu@gmail.com>
> ---
>  cmd/part.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/cmd/part.c b/cmd/part.c
> index 5e4e45ca6d..d78d914e7a 100644
> --- a/cmd/part.c
> +++ b/cmd/part.c
> @@ -25,6 +25,7 @@
>  enum cmd_part_info {
>  	CMD_PART_INFO_START = 0,
>  	CMD_PART_INFO_SIZE,
> +	CMD_PART_INFO_BLOCK,
>  	CMD_PART_INFO_NUMBER
>  };
>  
> @@ -151,6 +152,9 @@ static int do_part_info(int argc, char * const argv[], enum cmd_part_info param)
>  	case CMD_PART_INFO_SIZE:
>  		snprintf(buf, sizeof(buf), LBAF, info.size);
>  		break;
> +	case CMD_PART_INFO_BLOCK:
> +		snprintf(buf, sizeof(buf), LBAF, info.blksz);
> +		break;
>  	case CMD_PART_INFO_NUMBER:
>  		snprintf(buf, sizeof(buf), "0x%x", part);
>  		break;
> @@ -177,6 +181,11 @@ static int do_part_size(int argc, char * const argv[])
>  	return do_part_info(argc, argv, CMD_PART_INFO_SIZE);
>  }
>  
> +static int do_part_block(int argc, char * const argv[])
> +{
> +	return do_part_info(argc, argv, CMD_PART_INFO_BLOCK);
> +}
> +
>  static int do_part_number(int argc, char * const argv[])
>  {
>  	return do_part_info(argc, argv, CMD_PART_INFO_NUMBER);
> @@ -195,6 +204,8 @@ static int do_part(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  		return do_part_start(argc - 2, argv + 2);
>  	else if (!strcmp(argv[1], "size"))
>  		return do_part_size(argc - 2, argv + 2);
> +	else if (!strcmp(argv[1], "block"))
> +		return do_part_block(argc - 2, argv + 2);
>  	else if (!strcmp(argv[1], "number"))
>  		return do_part_number(argc - 2, argv + 2);
>  
> @@ -219,6 +230,9 @@ U_BOOT_CMD(
>  	"part size <interface> <dev> <part> <varname>\n"
>  	"    - set environment variable to the size of the partition (in blocks)\n"
>  	"      part can be either partition number or partition name\n"
> +	"part block <interface> <dev> <part> <varname>\n"
> +	"    - set environment variable to the size of the partition block\n"
> +	"      part can be either partition number or partition name\n"
>  	"part number <interface> <dev> <part> <varname>\n"
>  	"    - set environment variable to the partition number using the partition name\n"
>  	"      part must be specified as partition name"

I believe you can solve the problems mentioned in the cover letter with
setexpr to do the conversion so nak on this patch, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200602/efed1ccb/attachment.sig>

  reply	other threads:[~2020-06-02 17:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 10:20 [PATCH]: cmd: part: add part block command razvan.becheriu at gmail.com
2020-06-01 10:20 ` [PATCH] cmd: part: Add 'block' sub-command razvan.becheriu at gmail.com
2020-06-02 17:55   ` Tom Rini [this message]
2020-06-02 17:55 ` [PATCH]: cmd: part: add part block command Tom Rini
2020-06-02 18:08   ` razvan becheriu
2020-06-02 18:30     ` Tom Rini
2020-06-02 18:36     ` razvan becheriu
2020-06-02 18:51       ` Tom Rini
2020-06-02 19:23         ` razvan becheriu
2020-06-05 18:01           ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2020-04-21 22:13 [PATCH] cmd: part: Add 'block' sub-command razvan becheriu
2020-04-24 15:28 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602175556.GP21630@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox