From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 2 Jun 2020 20:38:53 -0400 Subject: [PATCH v1 1/2] net: cortina_ni: Addd eth support for Cortina Access CAxxxx SoCs In-Reply-To: References: <1591065866-5818-1-git-send-email-alex.nemirovsky@cortina-access.com> <20200602130217.GB21630@bill-the-cat> Message-ID: <20200603003853.GY21630@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 03, 2020 at 12:18:18AM +0000, Alex Nemirovsky wrote: > Hi Tom, > > > On Jun 2, 2020, at 6:02 AM, Tom Rini wrote: > > > > On Mon, Jun 01, 2020 at 07:44:25PM -0700, Alex Nemirovsky wrote: > > > >> From: Aaron Tseng > >> > >> Add Cortina Access Ethernet device driver for CAxxxx SoCs. > >> This driver supports both legacy and DM_ETH network models. > >> > >> Signed-off-by: Aaron Tseng > >> Signed-off-by: Alex Nemirovsky > >> > >> CC: Joe Hershberger > >> CC: Abbie Chang > >> CC: Tom Rini > > [snip] > >> +#define HEADER_A_SIZE 8 > >> +#define CORTINA_NI_DBG 1 > >> +/*define CORTINA_NI_DBG if individual rx,tx,init needs to be called */ > > > > We have pr_debug, etc, please use those and not a custom debug defiine. > > > >> +#ifdef CONFIG_DM_ETH > >> +#if CORTINA_NI_DBG > >> +static struct udevice *dbg_dev; > >> +#endif > >> +static struct udevice *curr_dev; > >> +#else > > > > The deadline for drivers to convert to DM for ethernet is v2020.07. > > Please rework to not introduce any legacy mode support. Thanks! > > For clarity, we are providing BOTH DM and Legacy mode support in our driver. > Is the request to REMOVE Legacy mode support, even though DM support is already provided to meet the 2020.07 requirement? Yes, remove the legacy code as there's no non-legacy users in upstream to support. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: