From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 3 Jun 2020 11:03:28 -0400 Subject: [PATCH v4 1/2] net: cortina_ni: Add eth support for Cortina Access CAxxxx SoCs In-Reply-To: <1591171519-10406-1-git-send-email-alex.nemirovsky@cortina-access.com> References: <1591171519-10406-1-git-send-email-alex.nemirovsky@cortina-access.com> Message-ID: <20200603150328.GA32287@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 03, 2020 at 01:05:18AM -0700, Alex Nemirovsky wrote: > From: Aaron Tseng > > Add Cortina Access Ethernet device driver for CAxxxx SoCs. > This driver supports only the DM_ETH network model. > > Signed-off-by: Aaron Tseng > Signed-off-by: Alex Nemirovsky > > CC: Joe Hershberger > CC: Abbie Chang > CC: Tom Rini > > --- > > Changes in v4: None > Changes in v3: > - Changed commit comment to state that only DM model is supported > - Removed blank line at end of C file > > Changes in v2: > - Remove legacy mode support > - Add support for additional SoC variants > - Remove unused variables > > MAINTAINERS | 4 + > drivers/net/Kconfig | 7 + > drivers/net/Makefile | 1 + > drivers/net/cortina_ni.c | 1909 ++++++++++++++++++++++++++++++++++++++++++++++ > drivers/net/cortina_ni.h | 592 ++++++++++++++ > 5 files changed, 2513 insertions(+) > create mode 100644 drivers/net/cortina_ni.c > create mode 100644 drivers/net/cortina_ni.h So, is there a similar driver in upstream Linux? This driver doesn't quite fit right. At an "easy" level, there's still the customer macro around debug statements and not using pr_debug(), and contains a whole lot of debug code. There's also code for a saturn platform, is that being upstreamed? There's a ton of union usage which is also uncommon. A small item is it looks like this has its own crc function, when we have those available already. There's also things like: > +enum ca_status_t ca_mdio_read(CA_IN unsigned int addr, > + CA_IN unsigned int offset, > + CA_OUT unsigned short *data) > +{ Where CA_IN / CA_OUT just don't fit. Which brings me back to why I asked the first question, this feels a lot like a driver for an RTOS or some other system was adapted to U-Boot, rather than writing a new driver for U-Boot based on internal knowledge of the part in question. And I think that applies to a lot of the drivers as seen in the NAND review as well. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: