From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] serial: Add missing Kconfig dependencies for debug consoles
Date: Thu, 4 Jun 2020 19:40:40 -0400 [thread overview]
Message-ID: <20200604234040.GY32287@bill-the-cat> (raw)
In-Reply-To: <4fbd0373ed4b10dda62371137c7d3a1c59fb0c7c.1590660308.git.michal.simek@xilinx.com>
On Thu, May 28, 2020 at 12:05:12PM +0200, Michal Simek wrote:
> Debug console is the part of serial driver in the same file. It means to be
> able to enable debug console you also need to enable driver itself.
> That's why add all dependecies and list only debug consoles which are
> enabled based on driver selection to avoid compilation error when user
> asks for certain debug console but driver is not enable for it.
>
> Error:
> aarch64-linux-gnu-ld.bfd: common/built-in.o: in function `putc':
> /home/monstr/data/disk/u-boot/common/console.c:513: undefined reference to `printch'
> aarch64-linux-gnu-ld.bfd: common/built-in.o: in function `puts':
> /home/monstr/data/disk/u-boot/common/console.c:563: undefined reference to `printch'
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200604/db29ce51/attachment.sig>
prev parent reply other threads:[~2020-06-04 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 10:05 [PATCH] serial: Add missing Kconfig dependencies for debug consoles Michal Simek
2020-05-29 0:28 ` Simon Glass
2020-06-04 23:40 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604234040.GY32287@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox