public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] Dockerfile: add libguestfs-tools package
Date: Fri, 5 Jun 2020 11:19:15 -0400	[thread overview]
Message-ID: <20200605151915.GI32287@bill-the-cat> (raw)
In-Reply-To: <20200530221658.50842-1-xypron.glpk@gmx.de>

On Sun, May 31, 2020 at 12:16:58AM +0200, Heinrich Schuchardt wrote:

> In some of our Python tests we build disk images. Currently this involves
> using the sudo command for losetup and mount. For some tests sudo is
> not necessary if the command guestmount of package libguestfs-tools is
> available. Another useful tool in libguestfs-tools is virt-make-fs.
> 
> Generally we should get rid of using a root user for building and testing.
> As a first step install libguestfs-tools in our Docker image.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  Dockerfile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Dockerfile b/Dockerfile
> index 4138415..20a861f 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -57,6 +57,7 @@ RUN apt-get update && apt-get install -y \
>  	iasl \
>  	imagemagick \
>  	iputils-ping \
> +	libguestfs-tools \
>  	libisl15 \
>  	liblz4-tool \
>  	libpixman-1-dev \

I haven't applied this as in order to also convert any of the tests to
libguestfs-tools based approaches, Azure/GitLab (or Travis even) can be
locally modified to point at your own fork of the image.  If you really
need me to push this change to unblock further conversion please let me
know, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200605/1b9616d6/attachment.sig>

  reply	other threads:[~2020-06-05 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30 22:16 [PATCH 1/1] Dockerfile: add libguestfs-tools package Heinrich Schuchardt
2020-06-05 15:19 ` Tom Rini [this message]
2020-06-08  1:25   ` AKASHI Takahiro
2020-06-10 16:13     ` Tom Rini
2020-06-19 13:24 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605151915.GI32287@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox