From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH]: cmd: part: add part block command
Date: Fri, 5 Jun 2020 14:01:02 -0400 [thread overview]
Message-ID: <20200605180102.GA24893@bill-the-cat> (raw)
In-Reply-To: <CAJAoKi-Rd2iYHsSJx+1M35iSmsH6KAXnF1vy+TeeoL+x6RJHfg@mail.gmail.com>
On Tue, Jun 02, 2020 at 12:23:52PM -0700, razvan becheriu wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> hm...
>
> It seems that the changes never reached upstream:
>
> git://github.com/01org/edison-u-boot.git branch edison-v2014.04
>
> this branch was implementing 'part info' sub-command which was useful to
> retrieve partition info.
Ah, I thought it might be something like this, thanks for digging in to
it.
> the new repo:
>
> git://github.com/edison-fw/u-boot.git branch acpi-v2020.04 does implement
> 'part number' but does not implement neither 'info' or 'block'.
>
> I do not insist for you to take this patch, but I think it is useful (it is
> the simplest version which supports all needed functionality).
>
> If you think the same, let me know. I can change name of the sub-command or
> implement this in a different way, if needed.
I think for now I just want to defer on this. We just aren't at the
point where we can't solve this by knowing ahead of time what the
blocksize is. I'm sure it will be a problem at some point, but the
other part of the problem is figuring out how to add this functionality
in an opt-in way that still looks clean when written. If you have some
ideas on that however, I'd be happy to review. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200605/11f1a986/attachment.sig>
prev parent reply other threads:[~2020-06-05 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 10:20 [PATCH]: cmd: part: add part block command razvan.becheriu at gmail.com
2020-06-01 10:20 ` [PATCH] cmd: part: Add 'block' sub-command razvan.becheriu at gmail.com
2020-06-02 17:55 ` Tom Rini
2020-06-02 17:55 ` [PATCH]: cmd: part: add part block command Tom Rini
2020-06-02 18:08 ` razvan becheriu
2020-06-02 18:30 ` Tom Rini
2020-06-02 18:36 ` razvan becheriu
2020-06-02 18:51 ` Tom Rini
2020-06-02 19:23 ` razvan becheriu
2020-06-05 18:01 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605180102.GA24893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox