[EXT] [PATCH 24/30] arm: imx: Finish migration of CONFIG_CSF_SIZE to Kconfig

Tom Rini
2020-06-11T21:16:35Z

On Thu, Jun 11, 2020 at 08:11:57AM -0400, Tom Rini wrote:
> On Thu, Jun 11, 2020 at 05:28:45AM +0000, Ye Li wrote:
> > Hi Tom,
> >
> > > -----Original Message-----
> > > From: Tom Rini <trini@konsulko.com>
> > > Sent: 2020?6?11? 4:16
> > > To: u-boot at lists.denx.de
> > > Cc: Stefano Babic <sbabic@denx.de>; Fabio Estevam
> > > <festevam@gmail.com>; dl-uboot-imx <uboot-imx@nxp.com>
> > > Subject: [EXT] [PATCH 24/30] arm: imx: Finish migration of CONFIG_CSF_SIZE
> > > to Kconfig
> > >
> > > Caution: EXT Email
> > >
> > > While the normal case of CSF_SIZE is handled via Kconfig we have entries in
> > > config headers related to CONFIG_SECURE_BOOT. However in commit
> > > d714a75fd4dc ("imx: replace CONFIG_SECURE_BOOT with
> > > CONFIG_IMX_HAB") this was renamed to CONFIG_IMX_HAB. Update the
> > > CSF_SIZE entry to have the correct default value if we have IMX_HAB
> > > enabled.
> > >
> > > Cc: Stefano Babic <sbabic@denx.de>
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: NXP i.MX U-Boot Team <uboot-imx@nxp.com>
> > > Fixes: d714a75fd4dc ("imx: replace CONFIG_SECURE_BOOT with
> > > CONFIG_IMX_HAB")
> > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > ---
> > > arch/arm/mach-imx/Kconfig | 1 +
> > > include/configs/imx8mm_beacon.h | 4 ----
> > > include/configs/imx8mm_evk.h | 4 ----
> > > include/configs/imx8mn_evk.h | 4 ----
> > > include/configs/imx8mp_evk.h | 4 ----
> > > include/configs/verdin-imx8mm.h | 4 ----
> > > 6 files changed, 1 insertion(+), 20 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index
> > > 6c3fedf665d6..0648c2725bf8 100644
> > > --- a/arch/arm/mach-imx/Kconfig
> > > +++ b/arch/arm/mach-imx/Kconfig
> > > @@ -52,6 +52,7 @@ config IMX_HAB
> > >
> > > config CSF_SIZE
> > > hex "Maximum size for Command Sequence File (CSF) binary"
> > > + default 0x2000 if IMX_HAB
> > I suggest using "default 0x2000 if ARCH_IMX8M", because i.MX6/7 may also enable IMX_HAB.
>
> So ARCH_IMX8M && IMX_HAB? I would have expected the CSF size to be
> limited in all cases from the default value due to something security
> related eating up that 0x60 in overhead. Is that not the case? Thanks!

Ah, looking at the actual usage now, I get it. I'll make a v2 that has
the right ddefault for ARCH_IMX8M and make CSF_SIZE itself depend on
IMX_HAB.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200611/0e5b2b87/attachment.sig>