From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 28/30] spi: Enable missing CONFIG_SPL_DM_SPI support
Date: Wed, 10 Jun 2020 18:01:30 -0400 [thread overview]
Message-ID: <20200610220130.GP24893@bill-the-cat> (raw)
In-Reply-To: <0b081e02-323e-2308-3554-5176100f944c@denx.de>
On Wed, Jun 10, 2020 at 11:52:33PM +0200, Marek Vasut wrote:
> On 6/10/20 11:48 PM, Tom Rini wrote:
> > On Wed, Jun 10, 2020 at 05:01:21PM -0400, Tom Rini wrote:
> >> On Wed, Jun 10, 2020 at 10:38:45PM +0200, Marek Vasut wrote:
> >>> On 6/10/20 10:16 PM, Tom Rini wrote:
> >>> [...]
> >>>> configs/socfpga_dbm_soc1_defconfig | 1 +
> >>>> configs/socfpga_de0_nano_soc_defconfig | 1 +
> >>>> configs/socfpga_de10_nano_defconfig | 1 +
> >>>> configs/socfpga_de1_soc_defconfig | 1 +
> >>>
> >>> I don't think those de*_soc boards have a SPI NOR at all.
> >>> And I'm also afraid that enabling this will make those boards overflow
> >>> SPL size limits.
> >>
> >> There is zero size change from this patch on any platform included in
> >> this patch.
> >>
> >> Today each of the boards you mention enables CONFIG_SPL_SPI_SUPPORT,
> >> CONFIG_SPL_SPI_FLASH_SUPPORT and then CONFIG_SPL_SPI_FLASH_TINY.
> >>
> >> That said, that means you aren't using SPL_DM_SPI for real, so I'll go
> >> take a look at what to change instead in the previous patch, thanks!
> >
> > Nope, check your platforms again. Based on looking over
> > socfpga_de1_soc/spl/u-boot-spl.map it's not discarding a bunch of the DM
> > SPI stuff as we're in fact building it today, and using the few
> > functions that spi-mem-nodm.c provides from spi-mem.c instead. So this
> > is correct for what's happening today.
>
> Are you _sure_ the board has a SPI NOR on it at all ? I doubt all of
> them do, so it seems some of those SPL DM SPI are copy-paste errors.
I'm only as sure as what the board maintainer enabled. As they're on CC
and see the answer is "Oh, I don't even have flash!" then they should go
and fix that. My point is that it's not changing any platform sizes and
is being explicit about what is implicit today based on the build logic
in use.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/6ab927c7/attachment.sig>
next prev parent reply other threads:[~2020-06-10 22:01 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 20:16 [PATCH 00/30] Finish some Kconfig migrations Tom Rini
2020-06-10 20:16 ` [PATCH 01/30] Convert CONFIG_AM335X_LCD to Kconfig Tom Rini
2020-06-10 20:16 ` [PATCH 02/30] Convert CONFIG_ARCH_MISC_INIT " Tom Rini
2020-06-10 20:16 ` [PATCH 03/30] Convert CONFIG_ARM_PL180_MMCI " Tom Rini
2020-06-10 20:16 ` [PATCH 04/30] Convert CONFIG_ARMV7_PSCI et al " Tom Rini
2020-06-10 20:16 ` [PATCH 05/30] Convert CONFIG_AT91_GPIO " Tom Rini
2020-06-10 20:16 ` [PATCH 06/30] Convert CONFIG_ATMEL_HLCD " Tom Rini
2020-06-10 20:16 ` [PATCH 07/30] Convert CONFIG_ATMEL_NAND_HW_PMECC et al " Tom Rini
2020-06-10 20:16 ` [PATCH 08/30] Convert CONFIG_ATMEL_USART " Tom Rini
2020-06-10 20:16 ` [PATCH 09/30] bk4r1: Re-convert CONFIG_AUTOBOOT_PROMPT et al " Tom Rini
2020-06-10 20:16 ` [PATCH 10/30] Convert CONFIG_BAUDRATE " Tom Rini
2020-06-10 20:16 ` [PATCH 11/30] Convert CONFIG_BOARD_EARLY_INIT_F et al " Tom Rini
2020-06-10 20:16 ` [PATCH 12/30] Convert CONFIG_BOOTARGS " Tom Rini
2020-06-10 20:16 ` [PATCH 13/30] Convert CONFIG_BCH " Tom Rini
2020-06-10 20:16 ` [PATCH 14/30] Convert CONFIG_BOARD_TYPES " Tom Rini
2020-06-10 20:16 ` [PATCH 15/30] arm: capricorn: Convert CONFIG_BOOTCOUNT_ENV et al " Tom Rini
2020-06-10 20:16 ` [PATCH 16/30] arm: abb secu1: Convert CONFIG_BOOTDELAY " Tom Rini
2020-06-12 7:26 ` Holger Brunck
2020-06-10 20:16 ` [PATCH 17/30] Convert CONFIG_BOOTP_DNS2 " Tom Rini
2020-06-10 20:16 ` [PATCH 18/30] Convert CONFIG_BOUNCE_BUFFER " Tom Rini
2020-06-10 20:16 ` [PATCH 19/30] Convert CONFIG_BUILD_TARGET " Tom Rini
2020-06-10 20:16 ` [PATCH 20/30] Convert CONFIG_CMDLINE_EDITING " Tom Rini
2020-06-10 20:16 ` [PATCH 21/30] Convert CONFIG_CONS_INDEX " Tom Rini
2020-06-10 20:16 ` [PATCH 22/30] arm: toradex: Convert CONFIG_CONSOLE_MUX " Tom Rini
2020-06-11 14:35 ` Igor Opaniuk
2020-06-10 20:16 ` [PATCH 23/30] Convert CONFIG_CONSOLE_SCROLL_LINES " Tom Rini
2020-06-10 20:16 ` [PATCH 24/30] arm: imx: Finish migration of CONFIG_CSF_SIZE " Tom Rini
2020-06-11 5:28 ` [EXT] " Ye Li
2020-06-11 12:11 ` Tom Rini
2020-06-11 21:16 ` Tom Rini
2020-06-10 20:16 ` [PATCH 25/30] arm: imx: Finish migration from CONFIG_SECURE_BOOT to CONFIG_IMX_HAB Tom Rini
2020-06-11 19:31 ` Vladimir Oltean
2020-06-11 20:30 ` Tom Rini
2020-06-11 21:02 ` Vladimir Oltean
2020-06-11 21:07 ` Tom Rini
2020-06-10 20:16 ` [PATCH 26/30] Convert CONFIG_BOOTM_NETBSD to Kconfig Tom Rini
2020-06-10 20:16 ` [PATCH 27/30] Kconfig: Remove CONFIG_CLOCKS_IN_MHZ Tom Rini
2020-06-10 20:16 ` [PATCH 28/30] spi: Enable missing CONFIG_SPL_DM_SPI support Tom Rini
2020-06-10 20:38 ` Marek Vasut
2020-06-10 21:01 ` Tom Rini
2020-06-10 21:48 ` Tom Rini
2020-06-10 21:52 ` Marek Vasut
2020-06-10 22:01 ` Tom Rini [this message]
2020-06-11 7:28 ` Patrick DELAUNAY
2020-06-11 10:38 ` Adam Ford
2020-06-11 12:17 ` Tom Rini
2020-06-12 2:09 ` Adam Ford
2020-06-12 2:24 ` Adam Ford
2020-06-12 7:59 ` Luca Ceresoli
2020-06-10 20:16 ` [PATCH 29/30] spi: Update build guard for DM objects to cover SPL/TPL Tom Rini
2020-06-10 20:16 ` [PATCH 30/30] Convert CONFIG_CADENCE_QSPI to Kconfig Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610220130.GP24893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox