From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 16 Jun 2020 10:17:46 -0400 Subject: [PATCH] checkpatch: fix a false check against wchar/utf-16 string In-Reply-To: <20200616054307.6017-1-takahiro.akashi@linaro.org> References: <20200616054307.6017-1-takahiro.akashi@linaro.org> Message-ID: <20200616141746.GU24893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jun 16, 2020 at 02:43:07PM +0900, AKASHI Takahiro wrote: > UEFI subsystem uses utf-16 string, but checkpatch.pl complains > about any occurrences of L"xxx" which is definitely legal. > So just suppress this kind of warning. > Precautiously, we will check u"xxx" as well. > > Signed-off-by: AKASHI Takahiro > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index edba36565167..b3697720787c 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -5462,7 +5462,7 @@ sub process { > } > > # concatenated string without spaces between elements > - if ($line =~ /$String[A-Za-z0-9_]/ || $line =~ /[A-Za-z0-9_]$String/) { > + if ($line =~ /$String[A-Za-z0-9_]/ || $line =~ /([A-Za-z0-9_]+[Lu]|[A-Za-z0-9_]*[A-KM-Za-tv-z0-9_])$String/) { > if (CHK("CONCATENATED_STRING", > "Concatenated strings should use spaces between elements\n" . $herecurr) && > $fix) { This looks like a generic checkpatch issue. I think we're a little out of sync with the kernel's v5.7 but this doesn't look to be fixed there either. Can you please submit it upstream? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: