public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: sbabic at denx.de <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v3 1/4] phy: atheros: ar8035: Fix clock output calculation
Date: Tue, 23 Jun 2020 09:51:31 +0200 (CEST)	[thread overview]
Message-ID: <20200623075131.C6AA081F06@phobos.denx.de> (raw)
In-Reply-To: <20200618232120.3289-1-festevam@gmail.com>

> The clock ouput frequency is calculated incorrectly for AR8035 due to
> wrong masking of priv->clk_25m_reg and priv->clk_25m_mask.
> This same issue has been already fixed in the kernel by:
> commit b1f4c209d84057b6d40b939b6e4404854271d797
> Author: Oleksij Rempel <o.rempel@pengutronix.de>
> Date:   Wed Apr 1 11:57:32 2020 +0200
>     net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035
>     The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
>     for the values that comprise the fields, not zero-bits-set.
>     This patch fixes the clock frequency configuration for ATH8030 and
>     ATH8035 Atheros PHYs by removing the erroneous "~".
>     To reproduce this bug, configure the PHY  with the device tree binding
>     "qca,clk-out-frequency" and remove the machine specific PHY fixups.
>     Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
>     Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>     Reported-by: Russell King <rmk+kernel@armlinux.org.uk>
>     Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
>     Tested-by: Russell King <rmk+kernel@armlinux.org.uk>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> Apply the same fix in the U-Boot driver.
> Tested on a i.MX6 Hummingboard.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Michael Walle <michael@walle.cc>
> Tested-by: Tom Rini <trini@konsulko.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2020-06-23  7:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 23:21 [PATCH v3 1/4] phy: atheros: ar8035: Fix clock output calculation Fabio Estevam
2020-06-18 23:21 ` [PATCH v3 2/4] net: fec: Allow the PHY node to be retrieved Fabio Estevam
2020-06-23  7:51   ` sbabic at denx.de
2020-06-18 23:21 ` [PATCH v3 3/4] ARM: dts: imx6qdl-sr-som: Sync with kernel 5.8-rc1 Fabio Estevam
2020-06-23  7:50   ` sbabic at denx.de
2020-06-18 23:21 ` [PATCH v3 4/4] mx6cuboxi: Convert to DM_ETH Fabio Estevam
2020-06-23  7:50   ` sbabic at denx.de
2020-06-23  7:51 ` sbabic at denx.de [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623075131.C6AA081F06@phobos.denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox