From: Patrick Delaunay <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 06/14] env: the ops driver load becomes mandatory in struct env_driver
Date: Thu, 25 Jun 2020 09:59:50 +0200 [thread overview]
Message-ID: <20200625075958.9868-7-patrick.delaunay@st.com> (raw)
In-Reply-To: <20200625075958.9868-1-patrick.delaunay@st.com>
The ops driver load becomes mandatory in struct env_drive,
change the comment for this ops and remove unnecessary test.
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
Changes in v3:
- new: load operation becomes mandatory
env/env.c | 3 ---
include/env_internal.h | 3 +--
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/env/env.c b/env/env.c
index 181aaa222c..a1696cd77e 100644
--- a/env/env.c
+++ b/env/env.c
@@ -187,9 +187,6 @@ int env_load(void)
for (prio = 0; (drv = env_driver_lookup(ENVOP_LOAD, prio)); prio++) {
int ret;
- if (!drv->load)
- continue;
-
if (!env_has_inited(drv->location))
continue;
diff --git a/include/env_internal.h b/include/env_internal.h
index 66550434c3..795941daee 100644
--- a/include/env_internal.h
+++ b/include/env_internal.h
@@ -154,8 +154,7 @@ struct env_driver {
/**
* load() - Load the environment from storage
*
- * This method is optional. If not provided, no environment will be
- * loaded.
+ * This method is required for loading environment
*
* @return 0 if OK, -ve on error
*/
--
2.17.1
next prev parent reply other threads:[~2020-06-25 7:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 7:59 [PATCH v3 00/14] env: ext4: corrections and add test for env in ext4 Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 01/14] env: add absolute path at CONFIG_ENV_EXT4_FILE Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 02/14] env: ext4: set gd->env_valid Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 03/14] env: sf: avoid space in backend name Patrick Delaunay
2020-06-26 20:54 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 04/14] env: correctly handle env_load_prio Patrick Delaunay
2020-06-26 20:55 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 05/14] env: nowhere: add .load ops Patrick Delaunay
2020-06-26 20:55 ` Tom Rini
2020-07-26 20:50 ` Tom Rini
2020-06-25 7:59 ` Patrick Delaunay [this message]
2020-06-26 20:55 ` [PATCH v3 06/14] env: the ops driver load becomes mandatory in struct env_driver Tom Rini
2020-06-25 7:59 ` [PATCH v3 07/14] cmd: env: add env load command Patrick Delaunay
2020-06-26 20:55 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 08/14] cmd: env: add env select command Patrick Delaunay
2020-06-26 20:54 ` Tom Rini
2020-06-30 11:42 ` Patrick DELAUNAY
2020-06-25 7:59 ` [PATCH v3 09/14] configs: sandbox: activate env in ext4 support Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 10/14] configs: sandbox: activate command env select and env load Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 11/14] test: environment in ext4 Patrick Delaunay
2020-07-06 21:53 ` Stephen Warren
2020-06-25 7:59 ` [PATCH v3 12/14] env: ext4: introduce new function env_ext4_save_buffer Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 13/14] env: ext4: add support of command env erase Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 14/14] test: sandbox: add test for erase command Patrick Delaunay
2020-07-06 21:54 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625075958.9868-7-patrick.delaunay@st.com \
--to=patrick.delaunay@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox