* [PATCH] rk3399: Add BOOTENV_SF command
@ 2020-06-08 14:17 Jagan Teki
2020-06-25 15:02 ` Jagan Teki
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jagan Teki @ 2020-06-08 14:17 UTC (permalink / raw)
To: u-boot
Add missing BOOTENV_SF command in rk3399 config.
Fix it.
Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
---
include/configs/rk3399_common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
index f0ae6e67a7..e63ebb14f7 100644
--- a/include/configs/rk3399_common.h
+++ b/include/configs/rk3399_common.h
@@ -67,6 +67,7 @@
"partitions=" PARTS_DEFAULT \
ROCKCHIP_DEVICE_SETTINGS \
BOOTENV \
+ BOOTENV_SF \
"altbootcmd=" \
"setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
"run distro_bootcmd\0"
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] rk3399: Add BOOTENV_SF command
2020-06-08 14:17 [PATCH] rk3399: Add BOOTENV_SF command Jagan Teki
@ 2020-06-25 15:02 ` Jagan Teki
2020-06-26 20:21 ` Tom Rini
2020-06-27 14:05 ` Kever Yang
2020-06-27 14:06 ` Kever Yang
2 siblings, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2020-06-25 15:02 UTC (permalink / raw)
To: u-boot
On Mon, Jun 8, 2020 at 7:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Add missing BOOTENV_SF command in rk3399 config.
>
> Fix it.
>
> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
> ---
Can someone push this fix patch to master?
Jagan.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] rk3399: Add BOOTENV_SF command
2020-06-25 15:02 ` Jagan Teki
@ 2020-06-26 20:21 ` Tom Rini
2020-06-27 14:05 ` Kever Yang
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2020-06-26 20:21 UTC (permalink / raw)
To: u-boot
On Thu, Jun 25, 2020 at 08:32:10PM +0530, Jagan Teki wrote:
> On Mon, Jun 8, 2020 at 7:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > Add missing BOOTENV_SF command in rk3399 config.
> >
> > Fix it.
> >
> > Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> > Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
> > ---
>
> Can someone push this fix patch to master?
Kever, do you want me to pick this up? Do you have some objection?
FWIW, include/configs/rk3399_common.h should get listed under some
MAINTAINER entry directly. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200626/3c494479/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] rk3399: Add BOOTENV_SF command
2020-06-26 20:21 ` Tom Rini
@ 2020-06-27 14:05 ` Kever Yang
0 siblings, 0 replies; 6+ messages in thread
From: Kever Yang @ 2020-06-27 14:05 UTC (permalink / raw)
To: u-boot
Hi Tom,
On 2020/6/27 ??4:21, Tom Rini wrote:
> On Thu, Jun 25, 2020 at 08:32:10PM +0530, Jagan Teki wrote:
>> On Mon, Jun 8, 2020 at 7:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>>> Add missing BOOTENV_SF command in rk3399 config.
>>>
>>> Fix it.
>>>
>>> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
>>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>>> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
>>> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
>>> ---
>> Can someone push this fix patch to master?
> Kever, do you want me to pick this up? Do you have some objection?
> FWIW, include/configs/rk3399_common.h should get listed under some
> MAINTAINER entry directly. Thanks!
I will apply this patch and send to fix RP.
Thanks,
- Kever
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] rk3399: Add BOOTENV_SF command
2020-06-08 14:17 [PATCH] rk3399: Add BOOTENV_SF command Jagan Teki
2020-06-25 15:02 ` Jagan Teki
@ 2020-06-27 14:05 ` Kever Yang
2020-06-27 14:06 ` Kever Yang
2 siblings, 0 replies; 6+ messages in thread
From: Kever Yang @ 2020-06-27 14:05 UTC (permalink / raw)
To: u-boot
On 2020/6/8 ??10:17, Jagan Teki wrote:
> Add missing BOOTENV_SF command in rk3399 config.
>
> Fix it.
>
> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> include/configs/rk3399_common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index f0ae6e67a7..e63ebb14f7 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -67,6 +67,7 @@
> "partitions=" PARTS_DEFAULT \
> ROCKCHIP_DEVICE_SETTINGS \
> BOOTENV \
> + BOOTENV_SF \
> "altbootcmd=" \
> "setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
> "run distro_bootcmd\0"
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] rk3399: Add BOOTENV_SF command
2020-06-08 14:17 [PATCH] rk3399: Add BOOTENV_SF command Jagan Teki
2020-06-25 15:02 ` Jagan Teki
2020-06-27 14:05 ` Kever Yang
@ 2020-06-27 14:06 ` Kever Yang
2 siblings, 0 replies; 6+ messages in thread
From: Kever Yang @ 2020-06-27 14:06 UTC (permalink / raw)
To: u-boot
On 2020/6/8 ??10:17, Jagan Teki wrote:
> Add missing BOOTENV_SF command in rk3399 config.
>
> Fix it.
>
> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
Applied to u-boot-rockchip master branch.
> ---
> include/configs/rk3399_common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index f0ae6e67a7..e63ebb14f7 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -67,6 +67,7 @@
> "partitions=" PARTS_DEFAULT \
> ROCKCHIP_DEVICE_SETTINGS \
> BOOTENV \
> + BOOTENV_SF \
> "altbootcmd=" \
> "setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
> "run distro_bootcmd\0"
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-27 14:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-08 14:17 [PATCH] rk3399: Add BOOTENV_SF command Jagan Teki
2020-06-25 15:02 ` Jagan Teki
2020-06-26 20:21 ` Tom Rini
2020-06-27 14:05 ` Kever Yang
2020-06-27 14:05 ` Kever Yang
2020-06-27 14:06 ` Kever Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox