From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 08/14] cmd: env: add env select command
Date: Fri, 26 Jun 2020 16:54:47 -0400 [thread overview]
Message-ID: <20200626205447.GE8432@bill-the-cat> (raw)
In-Reply-To: <20200625075958.9868-9-patrick.delaunay@st.com>
On Thu, Jun 25, 2020 at 09:59:52AM +0200, Patrick Delaunay wrote:
> Add the new command 'env select' to force the persistent storage
> of environment, saved in gd->env_load_prio.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
[snip]
> + /* search priority by driver */
> + for (prio = 0; (drv = env_driver_lookup(ENVOP_INIT, prio)); prio++) {
> + if (entry->location == env_get_location(ENVOP_LOAD, prio)) {
> + /* when priority change, reset the ENV flags */
> + if (gd->env_load_prio != prio) {
> + gd->env_load_prio = prio;
> + gd->env_valid = ENV_INVALID;
> + gd->flags &= ~GD_FLG_ENV_DEFAULT;
> + }
> + printf("OK\n");
> + return 0;
> + }
> + }
So, after we do this, is some follow up env command required to
initialize the environment to now exist somewhere else? Or will we have
initialized all configured locations during boot, and don't have to?
But what will happen if we select say "nand" but it's not present so
didn't init. Will things fail gracefully (not panic) ? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200626/1e282377/attachment.sig>
next prev parent reply other threads:[~2020-06-26 20:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 7:59 [PATCH v3 00/14] env: ext4: corrections and add test for env in ext4 Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 01/14] env: add absolute path at CONFIG_ENV_EXT4_FILE Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 02/14] env: ext4: set gd->env_valid Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 03/14] env: sf: avoid space in backend name Patrick Delaunay
2020-06-26 20:54 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 04/14] env: correctly handle env_load_prio Patrick Delaunay
2020-06-26 20:55 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 05/14] env: nowhere: add .load ops Patrick Delaunay
2020-06-26 20:55 ` Tom Rini
2020-07-26 20:50 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 06/14] env: the ops driver load becomes mandatory in struct env_driver Patrick Delaunay
2020-06-26 20:55 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 07/14] cmd: env: add env load command Patrick Delaunay
2020-06-26 20:55 ` Tom Rini
2020-06-25 7:59 ` [PATCH v3 08/14] cmd: env: add env select command Patrick Delaunay
2020-06-26 20:54 ` Tom Rini [this message]
2020-06-30 11:42 ` Patrick DELAUNAY
2020-06-25 7:59 ` [PATCH v3 09/14] configs: sandbox: activate env in ext4 support Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 10/14] configs: sandbox: activate command env select and env load Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 11/14] test: environment in ext4 Patrick Delaunay
2020-07-06 21:53 ` Stephen Warren
2020-06-25 7:59 ` [PATCH v3 12/14] env: ext4: introduce new function env_ext4_save_buffer Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 13/14] env: ext4: add support of command env erase Patrick Delaunay
2020-06-25 7:59 ` [PATCH v3 14/14] test: sandbox: add test for erase command Patrick Delaunay
2020-07-06 21:54 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626205447.GE8432@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox