[PATCH 03/16] dh_imx6: Switch to full DM-aware

Tom Rini
2020-06-22T12:32:19Z

On Mon, Jun 22, 2020 at 09:38:36AM +0000, Ludwig Zenz wrote:

> On 6/13/20 3:55 PM, Jagan Teki wrote:
> > Enable DM_SPI/DM_SPI_FLASH with a related config option.
> >
> > Build fine, but not tested.
>
> Hello,
>
> due to memory limitations in the SRAM of the i.MX6S in SPL we have not used the device tree. Have the restrictions been removed in the meantime? We need a single binary for the i.MX6 q/d/dl/s variants of our system on module.
>
> I think this patch breaks the board support for our module.

I _think_ i.MX is making use of the generic hooks to cause build time
failures when we grow too large. And we have addressed some, but not
all of the concerns about DM size. Can you please test this patch? If
it doesn't work doing:

> > diff --git a/include/configs/dh_imx6.h b/include/configs/dh_imx6.h index 5bfdf4044b..5fb84f72a2 100644
> > --- a/include/configs/dh_imx6.h
> > +++ b/include/configs/dh_imx6.h
> > @@ -53,12 +53,6 @@
> > /* SATA Configs */
> > #define CONFIG_LBA48
> >
> > -/* SPI Flash Configs */
> > -#if defined(CONFIG_SPL_BUILD)
> > -#undef CONFIG_DM_SPI
> > -#undef CONFIG_DM_SPI_FLASH
> > -#endif

is still needed as we have a symbol to control DM SPI in SPL directly so
the above isn't doing what you imply you want. Thanks!

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200622/0dbcbe04/attachment.sig>