public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] gitlab: add pycrypto for arm64
Date: Mon, 29 Jun 2020 12:00:46 -0400	[thread overview]
Message-ID: <20200629160046.GV8432@bill-the-cat> (raw)
In-Reply-To: <20200628102052.2233-1-kever.yang@rock-chips.com>

On Sun, Jun 28, 2020 at 06:20:52PM +0800, Kever Yang wrote:

> pycrypto is needed for script to generate correct its.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  .gitlab-ci.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index f2e491c117..4841e7afbe 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -67,7 +67,7 @@ build all 64bit ARM platforms:
>    script:
>      - virtualenv -p /usr/bin/python3 /tmp/venv
>      - . /tmp/venv/bin/activate
> -    - pip install pyelftools
> +    - pip install pyelftools pycrypto
>      - ret=0;
>        ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
>        if [[ $ret -ne 0 ]]; then
> @@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
>        export USER=gitlab;
>        virtualenv -p /usr/bin/python3 /tmp/venv;
>        . /tmp/venv/bin/activate;
> -      pip install pyelftools pytest;
> +      pip install pyelftools pytest pycrypto;
>        export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
>        export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
>        export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";

We need to update all of the CI config files to install the needed
modules.  I also assume we haven't pushed changes in yet that require
pycrypto, so which tool is going to need it?  I want to make sure we
document it and perhaps we need to start thinking about a
requirement.txt for our python tools if it's binman that needs it (as
that's what also needs pyelftools).  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200629/12c13587/attachment.sig>

  reply	other threads:[~2020-06-29 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 10:20 [PATCH] gitlab: add pycrypto for arm64 Kever Yang
2020-06-29 16:00 ` Tom Rini [this message]
2020-06-30  9:17   ` Kever Yang
2020-06-30 12:33     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629160046.GV8432@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox