* [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places
@ 2020-07-03 20:58 Pali Rohár
2020-07-04 11:50 ` [maemo-leste] " Pavel Machek
2020-07-05 18:37 ` Faiz Abbas
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2020-07-03 20:58 UTC (permalink / raw)
To: u-boot
In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
was changed 3.0V IO voltage to 3.3V but it was not done on all places in
omap_hsmmc driver. That commit broke eMMC support on Nokia N900.
This patch fixes that problematic commit and changes 3.0V to 3.3V on all
remaining places in omap_hsmmc driver.
Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
Signed-off-by: Pali Roh?r <pali@kernel.org>
---
drivers/mmc/omap_hsmmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
index 8636cd713a..dc26e54795 100644
--- a/drivers/mmc/omap_hsmmc.c
+++ b/drivers/mmc/omap_hsmmc.c
@@ -840,7 +840,7 @@ static int omap_hsmmc_init_setup(struct mmc *mmc)
omap_hsmmc_conf_bus_power(mmc, (reg_val & VS33_3V3SUP) ?
MMC_SIGNAL_VOLTAGE_330 : MMC_SIGNAL_VOLTAGE_180);
#else
- writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V0, &mmc_base->hctl);
+ writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V3, &mmc_base->hctl);
writel(readl(&mmc_base->capa) | VS33_3V3SUP | VS18_1V8SUP,
&mmc_base->capa);
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [maemo-leste] [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places
2020-07-03 20:58 [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places Pali Rohár
@ 2020-07-04 11:50 ` Pavel Machek
2020-07-05 18:37 ` Faiz Abbas
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2020-07-04 11:50 UTC (permalink / raw)
To: u-boot
On Fri 2020-07-03 22:58:23, Pali Roh?r wrote:
> In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
> was changed 3.0V IO voltage to 3.3V but it was not done on all places in
> omap_hsmmc driver. That commit broke eMMC support on Nokia N900.
>
> This patch fixes that problematic commit and changes 3.0V to 3.3V on all
> remaining places in omap_hsmmc driver.
>
> Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
> Signed-off-by: Pali Roh?r <pali@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200704/2d9d7006/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places
2020-07-03 20:58 [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places Pali Rohár
2020-07-04 11:50 ` [maemo-leste] " Pavel Machek
@ 2020-07-05 18:37 ` Faiz Abbas
1 sibling, 0 replies; 3+ messages in thread
From: Faiz Abbas @ 2020-07-05 18:37 UTC (permalink / raw)
To: u-boot
Hi,
On 04/07/20 2:28 am, Pali Roh?r wrote:
> In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
> was changed 3.0V IO voltage to 3.3V but it was not done on all places in
> omap_hsmmc driver. That commit broke eMMC support on Nokia N900.
>
> This patch fixes that problematic commit and changes 3.0V to 3.3V on all
> remaining places in omap_hsmmc driver.
>
> Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
> Signed-off-by: Pali Roh?r <pali@kernel.org>
> ---
Reviewed-by: Faiz Abbas <faiz_abbas@ti.com>
Thanks,
Faiz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-05 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-03 20:58 [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places Pali Rohár
2020-07-04 11:50 ` [maemo-leste] " Pavel Machek
2020-07-05 18:37 ` Faiz Abbas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox