From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: CONFIG_NR_DRAM_BANKS in configs/rpi_4* deleted
Date: Wed, 8 Jul 2020 11:30:21 -0400 [thread overview]
Message-ID: <20200708153021.GL1306@bill-the-cat> (raw)
In-Reply-To: <744eb612-c67e-2d8f-7af4-7d8b861e838f@suse.com>
On Wed, Jul 08, 2020 at 05:21:59PM +0200, Matthias Brugger wrote:
> Hi Tom,
>
> I just realized that
> 88bd5b1793 ("configs: Resync with savedefconfig")
>
> Delete the CONFIG_NR_DRAM_BANKS entries as added in this patch, which leads
> to a regression in RPi4 (only one GB of memory visible to the kernel if you
> use Grub for booting).
>
> Is it generally wrong to add CONFIG_NR_DRAM_BANKS to the config files? What
> is the correct approach then?
So, if savedefconfig removes an entry from the file, it's not needed.
In this case we see:
config NR_DRAM_BANKS
int "Number of DRAM banks"
default 1 if ARCH_SUNXI || ARCH_OWL
default 4
help
This defines the number of DRAM banks.
In the top-level Kconfig file. Since you set it as 4 and 4 is the
default, that's what's used:
$ make O=/tmp/rpi_4 rpi_4_config -sj
$ grep NR_D /tmp/rpi_4/.config
CONFIG_NR_DRAM_BANKS=4
$ grep ARCH_FIX /tmp/rpi_4/.config
CONFIG_ARCH_FIXUP_FDT_MEMORY=y
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200708/e93eab07/attachment.sig>
prev parent reply other threads:[~2020-07-08 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 14:42 [PATCH] configs: rpi: set NR_DRAM_BANKS to four matthias.bgg at kernel.org
2020-07-08 15:21 ` CONFIG_NR_DRAM_BANKS in configs/rpi_4* deleted Matthias Brugger
2020-07-08 15:30 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708153021.GL1306@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox