From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 8 Jul 2020 11:30:21 -0400 Subject: CONFIG_NR_DRAM_BANKS in configs/rpi_4* deleted In-Reply-To: <744eb612-c67e-2d8f-7af4-7d8b861e838f@suse.com> References: <20200529144222.25599-1-matthias.bgg@kernel.org> <744eb612-c67e-2d8f-7af4-7d8b861e838f@suse.com> Message-ID: <20200708153021.GL1306@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jul 08, 2020 at 05:21:59PM +0200, Matthias Brugger wrote: > Hi Tom, > > I just realized that > 88bd5b1793 ("configs: Resync with savedefconfig") > > Delete the CONFIG_NR_DRAM_BANKS entries as added in this patch, which leads > to a regression in RPi4 (only one GB of memory visible to the kernel if you > use Grub for booting). > > Is it generally wrong to add CONFIG_NR_DRAM_BANKS to the config files? What > is the correct approach then? So, if savedefconfig removes an entry from the file, it's not needed. In this case we see: config NR_DRAM_BANKS int "Number of DRAM banks" default 1 if ARCH_SUNXI || ARCH_OWL default 4 help This defines the number of DRAM banks. In the top-level Kconfig file. Since you set it as 4 and 4 is the default, that's what's used: $ make O=/tmp/rpi_4 rpi_4_config -sj $ grep NR_D /tmp/rpi_4/.config CONFIG_NR_DRAM_BANKS=4 $ grep ARCH_FIX /tmp/rpi_4/.config CONFIG_ARCH_FIXUP_FDT_MEMORY=y -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: