* [PATCH] cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION
@ 2020-07-12 17:59 Jagan Teki
2020-07-13 0:20 ` Tom Rini
2020-08-06 12:10 ` Stefan Roese
0 siblings, 2 replies; 4+ messages in thread
From: Jagan Teki @ 2020-07-12 17:59 UTC (permalink / raw)
To: u-boot
SPI_FLASH_PROTECTION config item is never used in anywhere
in the U-Boot tree.
Drop it.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
cmd/mvebu/bubt.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c
index a27b0df8ae..b3b5844267 100644
--- a/cmd/mvebu/bubt.c
+++ b/cmd/mvebu/bubt.c
@@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
return -ENOMEDIUM;
}
-#ifdef CONFIG_SPI_FLASH_PROTECTION
- spi_flash_protect(flash, 0);
-#endif
erase_bytes = image_size +
(flash->erase_size - image_size % flash->erase_size);
printf("Erasing %d bytes (%d blocks) at offset 0 ...",
@@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)
else
printf("Done!\n");
-#ifdef CONFIG_SPI_FLASH_PROTECTION
- spi_flash_protect(flash, 1);
-#endif
-
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION
2020-07-12 17:59 [PATCH] cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION Jagan Teki
@ 2020-07-13 0:20 ` Tom Rini
2020-08-06 12:10 ` Stefan Roese
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2020-07-13 0:20 UTC (permalink / raw)
To: u-boot
On Sun, Jul 12, 2020 at 11:29:01PM +0530, Jagan Teki wrote:
> SPI_FLASH_PROTECTION config item is never used in anywhere
> in the U-Boot tree.
>
> Drop it.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> cmd/mvebu/bubt.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c
> index a27b0df8ae..b3b5844267 100644
> --- a/cmd/mvebu/bubt.c
> +++ b/cmd/mvebu/bubt.c
> @@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
> return -ENOMEDIUM;
> }
>
> -#ifdef CONFIG_SPI_FLASH_PROTECTION
> - spi_flash_protect(flash, 0);
> -#endif
> erase_bytes = image_size +
> (flash->erase_size - image_size % flash->erase_size);
> printf("Erasing %d bytes (%d blocks) at offset 0 ...",
> @@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)
> else
> printf("Done!\n");
>
> -#ifdef CONFIG_SPI_FLASH_PROTECTION
> - spi_flash_protect(flash, 1);
> -#endif
> -
> return ret;
> }
Add maintainers.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200712/3480d5cb/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION
2020-07-12 17:59 [PATCH] cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION Jagan Teki
2020-07-13 0:20 ` Tom Rini
@ 2020-08-06 12:10 ` Stefan Roese
2020-08-06 14:27 ` Stefan Roese
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Roese @ 2020-08-06 12:10 UTC (permalink / raw)
To: u-boot
On 12.07.20 19:59, Jagan Teki wrote:
> SPI_FLASH_PROTECTION config item is never used in anywhere
> in the U-Boot tree.
>
> Drop it.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> cmd/mvebu/bubt.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c
> index a27b0df8ae..b3b5844267 100644
> --- a/cmd/mvebu/bubt.c
> +++ b/cmd/mvebu/bubt.c
> @@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
> return -ENOMEDIUM;
> }
>
> -#ifdef CONFIG_SPI_FLASH_PROTECTION
> - spi_flash_protect(flash, 0);
> -#endif
> erase_bytes = image_size +
> (flash->erase_size - image_size % flash->erase_size);
> printf("Erasing %d bytes (%d blocks) at offset 0 ...",
> @@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)
> else
> printf("Done!\n");
>
> -#ifdef CONFIG_SPI_FLASH_PROTECTION
> - spi_flash_protect(flash, 1);
> -#endif
> -
> return ret;
> }
>
>
Viele Gr??e,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION
2020-08-06 12:10 ` Stefan Roese
@ 2020-08-06 14:27 ` Stefan Roese
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2020-08-06 14:27 UTC (permalink / raw)
To: u-boot
On 06.08.20 14:10, Stefan Roese wrote:
> On 12.07.20 19:59, Jagan Teki wrote:
>> SPI_FLASH_PROTECTION config item is never used in anywhere
>> in the U-Boot tree.
>>
>> Drop it.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot-marvell/master
Thanks,
Stefan
> Thanks,
> Stefan
>
>> ---
>> ? cmd/mvebu/bubt.c | 7 -------
>> ? 1 file changed, 7 deletions(-)
>>
>> diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c
>> index a27b0df8ae..b3b5844267 100644
>> --- a/cmd/mvebu/bubt.c
>> +++ b/cmd/mvebu/bubt.c
>> @@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
>> ????????? return -ENOMEDIUM;
>> ????? }
>> -#ifdef CONFIG_SPI_FLASH_PROTECTION
>> -??? spi_flash_protect(flash, 0);
>> -#endif
>> ????? erase_bytes = image_size +
>> ????????? (flash->erase_size - image_size % flash->erase_size);
>> ????? printf("Erasing %d bytes (%d blocks) at offset 0 ...",
>> @@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)
>> ????? else
>> ????????? printf("Done!\n");
>> -#ifdef CONFIG_SPI_FLASH_PROTECTION
>> -??? spi_flash_protect(flash, 1);
>> -#endif
>> -
>> ????? return ret;
>> ? }
>>
>
>
> Viele Gr??e,
> Stefan
>
Viele Gr??e,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-06 14:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-12 17:59 [PATCH] cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION Jagan Teki
2020-07-13 0:20 ` Tom Rini
2020-08-06 12:10 ` Stefan Roese
2020-08-06 14:27 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox