From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 15 Jul 2020 21:37:49 +0200 Subject: [PATCH 3/4] fs/squashfs: add sources for zlib decompression In-Reply-To: <20200709175148.17193-4-joaomarcos.costa@bootlin.com> References: <20200709175148.17193-1-joaomarcos.costa@bootlin.com> <20200709175148.17193-4-joaomarcos.costa@bootlin.com> Message-ID: <20200715213749.0e509fcf@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Joao, On Thu, 9 Jul 2020 19:51:47 +0200 Joao Marcos Costa wrote: > Add zlib (v1.2.11) functions to U-Boot. SquashFS depends on those > functions to decompress data from a raw disk image. The actual support > for zlib into SquashFS sources will be added in a follow-up commit. > > Signed-off-by: Joao Marcos Costa The header of the commit title is wrong, this commit is not touching fs/squashfs at all, but lib/zlib. I think the rest of the commit title are also misleading: I believe zlib decompression was already supported in U-Boot. But looking at the code, lib/gunzip.c already has a function called zunzip(), which seems to do pretty much the same thing: decompress from a memory buffer into another memory buffer. Are you sure you cannot use this existing zunzip() function ? zunzip() is already used by UBIFS. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com