public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] Revert "riscv: Allow use of reset drivers"
Date: Thu, 16 Jul 2020 12:10:32 +0800	[thread overview]
Message-ID: <20200716041031.GA6513@andestech.com> (raw)
In-Reply-To: <a8fce89d-3024-05b5-036c-24230e5ef7ad@gmail.com>

On Wed, Jul 08, 2020 at 03:04:42AM -0400, Sean Anderson wrote:
> On 7/8/20 2:44 AM, Bin Meng wrote:
> > From: Bin Meng <bin.meng@windriver.com>
> > 
> > This reverts commit 958a3f464c7f8ef7e10db9feb663e9e80445ce2f.
> > 
> > A more appropriate change below is already in mainline.
> > Commit fd31e4fd184f ("riscv: Do not build reset.c if SYSRESET is on")
> > 
> > Revert this patch, so that U-Boot can be built successfully for
> > SiFive Fu540 board.
> > 
> > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > ---
> > 
> >  arch/riscv/lib/reset.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/riscv/lib/reset.c b/arch/riscv/lib/reset.c
> > index 6008bbe..8779c61 100644
> > --- a/arch/riscv/lib/reset.c
> > +++ b/arch/riscv/lib/reset.c
> > @@ -7,7 +7,6 @@
> >  #include <command.h>
> >  #include <hang.h>
> >  
> > -#ifndef CONFIG_SYSRESET
> >  int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
> >  {
> >  	printf("resetting ...\n");
> > @@ -17,4 +16,3 @@ int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
> >  
> >  	return 0;
> >  }
> > -#endif
> > 
> 
> Reviewed-by: Sean Anderson <seanga2@gmail.com>

Reviewed-by: Leo Liang <ycliang@andestech.com>

      parent reply	other threads:[~2020-07-16  4:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  6:44 [PATCH 1/2] Revert "riscv: Allow use of reset drivers" Bin Meng
2020-07-08  6:44 ` [PATCH 2/2] Revert "Revert "riscv: sifive: fu540: Add gpio-restart support"" Bin Meng
2020-07-08  7:04 ` [PATCH 1/2] Revert "riscv: Allow use of reset drivers" Sean Anderson
2020-07-16  1:36   ` Bin Meng
     [not found]     ` <752D002CFF5D0F4FA35C0100F1D73F3FA472787E@ATCPCS16.andestech.com>
2020-07-16  7:06       ` Rick Chen
2020-07-16  7:15         ` Bin Meng
2020-07-16  4:10   ` Leo Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716041031.GA6513@andestech.com \
    --to=ycliang@andestech.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox