public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: patrick.oppenlander at gmail.com <patrick.oppenlander@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/3] mkimage: fit: handle FDT_ERR_NOSPACE when ciphering
Date: Fri, 17 Jul 2020 17:28:24 +1000	[thread overview]
Message-ID: <20200717072825.371105-2-patrick.oppenlander@gmail.com> (raw)
In-Reply-To: <20200717072825.371105-1-patrick.oppenlander@gmail.com>

From: Patrick Oppenlander <patrick.oppenlander@gmail.com>

This meant that the order of operations had to change. If we replace the
data property first then fail to add the data-size-unciphered property
the data will be ciphered again when retrying.

Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
---
 tools/image-host.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/tools/image-host.c b/tools/image-host.c
index 8fa1b9aba7..87ef79ef53 100644
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -399,25 +399,26 @@ int fit_image_write_cipher(void *fit, int image_noffset, int noffset,
 {
 	int ret = -1;
 
-	/* Remove unciphered data */
-	ret = fdt_delprop(fit, image_noffset, FIT_DATA_PROP);
+	/* add non ciphered data size */
+	ret = fdt_setprop_u32(fit, image_noffset, "data-size-unciphered", size);
+	if (ret == -FDT_ERR_NOSPACE) {
+		ret = -ENOSPC;
+		goto out;
+	}
 	if (ret) {
-		printf("Can't remove data (err = %d)\n", ret);
+		printf("Can't add unciphered data size (err = %d)\n", ret);
 		goto out;
 	}
 
 	/* Add ciphered data */
 	ret = fdt_setprop(fit, image_noffset, FIT_DATA_PROP,
 			  data_ciphered, data_ciphered_len);
-	if (ret) {
-		printf("Can't add ciphered data (err = %d)\n", ret);
+	if (ret == -FDT_ERR_NOSPACE) {
+		ret = -ENOSPC;
 		goto out;
 	}
-
-	/* add non ciphered data size */
-	ret = fdt_setprop_u32(fit, image_noffset, "data-size-unciphered", size);
 	if (ret) {
-		printf("Can't add unciphered data size (err = %d)\n", ret);
+		printf("Can't add ciphered data (err = %d)\n", ret);
 		goto out;
 	}
 
-- 
2.27.0

  reply	other threads:[~2020-07-17  7:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17  7:28 [PATCH 1/3] mkimage: fit: only process one cipher node patrick.oppenlander at gmail.com
2020-07-17  7:28 ` patrick.oppenlander at gmail.com [this message]
2020-07-29 15:02   ` [PATCH 2/3] mkimage: fit: handle FDT_ERR_NOSPACE when ciphering Philippe REYNES
2020-07-30  1:19     ` Patrick Oppenlander
2020-07-17  7:28 ` [PATCH 3/3] mkimage: fit: don't cipher ciphered data patrick.oppenlander at gmail.com
2020-07-29 17:17   ` Philippe REYNES
2020-07-30  1:27     ` Patrick Oppenlander
2020-07-27 23:45 ` [PATCH 1/3] mkimage: fit: only process one cipher node Simon Glass
2020-07-29 14:50 ` Philippe REYNES

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717072825.371105-2-patrick.oppenlander@gmail.com \
    --to=patrick.oppenlander@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox