From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 22 Jul 2020 14:44:59 -0400 Subject: Reproducibility regression with mx6cuboxi In-Reply-To: <0f740a9d-4095-d53a-1597-2413c65517aa@gmx.de> References: <874kq3xt2u.fsf@ponder> <0f740a9d-4095-d53a-1597-2413c65517aa@gmx.de> Message-ID: <20200722184459.GS6227@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jul 22, 2020 at 08:32:28PM +0200, Heinrich Schuchardt wrote: > On 19.07.20 20:23, Vagrant Cascadian wrote: > > The mx6cuboxi target no longer builds reproducibility on Debian. I've > > bisected it down to: > > > > eb9124f5748c96ffd548e50fd6989c3b5395b353 mx6cuboxi: enable OF_CONTROL with DM_MMC and DM_USB > > > > > > Based on the diffoscope output, it *might* have something to do with the > > changes to how board detection uses gpios: > > > > --- /tmp/tmpj_t0iqs7/control > > +++ /tmp/tmpj_t0iqs7/experiment-time > > ? --- /tmp/tmpj_t0iqs7/control/source-root > > ??? +++ /tmp/tmpj_t0iqs7/experiment-time/source-root > > ? ? --- /tmp/tmpj_t0iqs7/control/source-root/u-boot-with-spl.imx > > ? ??? +++ /tmp/tmpj_t0iqs7/experiment-time/source-root/u-boot-with-spl.imx > > ? ? @@ -4346,16 +4346,16 @@ > > ? ? 00010f90: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00010fa0: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00010fb0: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00010fc0: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00010fd0: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00010fe0: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00010ff0: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? -00011000: 2705 1956 7088 eb01 5f14 7b49 0008 565c '..Vp..._.{I..V\ > > ? ? -00011010: 1780 0000 1780 0000 9463 4032 1102 0500 .........c at 2.... > > ? ? +00011000: 2705 1956 36e7 7190 5f14 7b49 0008 565c '..V6.q._.{I..V\ > > ? ? +00011010: 1780 0000 1780 0000 de74 408a 1102 0500 .........t at ..... > > ? ? 00011020: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00011030: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > > ? ? 00011040: b800 00ea 14f0 9fe5 14f0 9fe5 14f0 9fe5 ................ > > ? ? 00011050: 14f0 9fe5 14f0 9fe5 14f0 9fe5 14f0 9fe5 ................ > > ? ? 00011060: 6000 8017 c000 8017 2001 8017 8001 8017 `....... ....... > > ? ? 00011070: e001 8017 4002 8017 a002 8017 efbe adde .... at ........... > > ? ? 00011080: 2000 9000 00f0 20e3 00f0 20e3 00f0 20e3 ..... ... ... . > > ? ? @@ -33330,15 +33330,15 @@ > > ? ? 00082310: 6c6f 636b 2d6d 6173 7465 7200 7369 6d70 lock-master.simp > > ? ? 00082320: 6c65 2d61 7564 696f 2d63 6172 642c 6672 le-audio-card,fr > > ? ? 00082330: 616d 652d 6d61 7374 6572 0073 696d 706c ame-master.simpl > > ? ? 00082340: 652d 6175 6469 6f2d 6361 7264 2c77 6964 e-audio-card,wid > > ? ? 00082350: 6765 7473 0073 696d 706c 652d 6175 6469 gets.simple-audi > > ? ? 00082360: 6f2d 6361 7264 2c72 6f75 7469 6e67 0073 o-card,routing.s > > ? ? 00082370: 6f75 6e64 2d64 6169 0064 6574 6563 742d ound-dai.detect- > > ? ? -00082380: 6770 696f 7300 6275 d00d feed 0000 9e9e gpios.bu........ > > ? ? +00082380: 6770 696f 7300 0023 d00d feed 0000 9e9e gpios..#........ > > In file 'u-boot' there is only one occurence of string "detect-gpios" > followed by "\0HUSH_NO_EVAL". > > In file 'u-boot.bin' I see a second occurence not followed by > "\0HUSH_NO_EVAL". > > The second instance is introduced fit-dtb.blob. > > fit-dtb.blob is created from dts/dt.dtb using the mkimage tool. > > The last bytes of dts/dtb are > > "routing.sound-dai\0detect-gpios\0" > > So it seems the mkimage tool is introducing the variable bytes after > "detect-gpios\0". Possibly it is not clearing buffers. Possibly the data leak that Marek pointed out a while back but we never cycled back on fixing only that and not changing padding stuff at the same time. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: