From: Brian Moyer <bdm310@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 0/1] Fix SPL_EARLY_BSS applying to normal build
Date: Sun, 26 Jul 2020 13:17:52 -0700 [thread overview]
Message-ID: <20200726201753.28004-1-bdm310@gmail.com> (raw)
SPL_CLEAR_BSS is called regardless of build type if
CONFIG_SPL_EARLY_BSS is defined. This seems to break u-boot proper
and doesn't seem like the correct behavior.
Early bss clearing in u-boot proper happens before relocation and
causes lots of problems because .rel.dyn and .bss overlap.
Changes in v2:
- Adding a check to the first SPL_CLEAR_BSS resulted in BSS never
getting cleared for u-boot proper. Added an or condition to the
second call.
- SPL_CLEAR_BSS is the only bss clearing operation. Renamed to
just CLEAR_BSS for clarity.
Brian Moyer (1):
arm: Add SPL build check to SPL early bss clear
arch/arm/lib/crt0.S | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.17.1
next reply other threads:[~2020-07-26 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 20:17 Brian Moyer [this message]
2020-07-26 20:17 ` [PATCH v2 1/1] arm: Add SPL build check to SPL early bss clear Brian Moyer
2020-08-05 20:28 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726201753.28004-1-bdm310@gmail.com \
--to=bdm310@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox