* [PATCH] mkimage: fit: fix import of external data
@ 2020-07-30 4:31 patrick.oppenlander at gmail.com
2020-08-08 12:29 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: patrick.oppenlander at gmail.com @ 2020-07-30 4:31 UTC (permalink / raw)
To: u-boot
From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
The external data is located after the mmapped FDT pointed to by
'old_fdt', not in the newly created FDT we are importing into at 'fdt'.
Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
---
tools/fit_image.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/fit_image.c b/tools/fit_image.c
index df310b53da..793df54449 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -606,8 +606,8 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
continue;
debug("Importing data size %x\n", len);
- ret = fdt_setprop(fdt, node, "data", fdt + data_base + buf_ptr,
- len);
+ ret = fdt_setprop(fdt, node, "data",
+ old_fdt + data_base + buf_ptr, len);
if (ret) {
debug("%s: Failed to write property: %s\n", __func__,
fdt_strerror(ret));
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] mkimage: fit: fix import of external data
2020-07-30 4:31 [PATCH] mkimage: fit: fix import of external data patrick.oppenlander at gmail.com
@ 2020-08-08 12:29 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2020-08-08 12:29 UTC (permalink / raw)
To: u-boot
On Thu, Jul 30, 2020 at 02:31:48PM +1000, patrick.oppenlander at gmail.com wrote:
> From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
>
> The external data is located after the mmapped FDT pointed to by
> 'old_fdt', not in the newly created FDT we are importing into at 'fdt'.
>
> Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200808/6e0d1c0c/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-08 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-30 4:31 [PATCH] mkimage: fit: fix import of external data patrick.oppenlander at gmail.com
2020-08-08 12:29 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox