From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] IPQ40xx: Add DRAM detection & FDT fixup
Date: Tue, 4 Aug 2020 09:44:57 -0400 [thread overview]
Message-ID: <20200804134457.GY6965@bill-the-cat> (raw)
In-Reply-To: <CA+HBbNGLdKbLG7FZbXmMCrXe0gTfZ8HtGfHZZasMO1_ZnCg2xQ@mail.gmail.com>
On Tue, Aug 04, 2020 at 01:20:56PM +0200, Robert Marko wrote:
> On Mon, Aug 3, 2020 at 4:39 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Mon, Aug 03, 2020 at 01:52:19PM +0200, Robert Marko wrote:
> >
> > > Fixup the Linux FDT with the detection of onboard DRAM as
> > > provided by SBL (Secondary boot loader) by reading
> > > the shared-memory region.
> > >
> > > Imported from Snapdragon target.
> > >
> > > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > > Cc: Luka Perkov <luka.perkov@sartura.hr>
> > > ---
> > > arch/arm/mach-ipq40xx/Makefile | 1 +
> > > arch/arm/mach-ipq40xx/dram.c | 99 +++++++++++++++++++++++
> > > arch/arm/mach-ipq40xx/include/mach/dram.h | 12 +++
> > > 3 files changed, 112 insertions(+)
> > > create mode 100644 arch/arm/mach-ipq40xx/dram.c
> > > create mode 100644 arch/arm/mach-ipq40xx/include/mach/dram.h
> >
> > Is this as-is? If so, we need to figure out something or another to
> > make sharing the code, rather than copying, possible. How are these
> > both grouped in the kernel? Thanks!
>
> Yes, the Snapdragon target uses the identical code.
> The kernel does not have code for this but rather relies on the
> bootloader to do it.
Right, but I mean what does the kernel do to avoid copying identical
code between these two platforms? I guess the answer is that for
arch/arm64 everything has been pushed out of arch/arm64/. So in this
case, the dram code should get moved to our drivers/ddr/ or drivers/ram/
depending on which place "dram.c" really belongs best.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200804/56217123/attachment.sig>
next prev parent reply other threads:[~2020-08-04 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 11:52 [PATCH 1/2] IPQ40xx: Add DRAM detection & FDT fixup Robert Marko
2020-08-03 11:52 ` [PATCH 2/2] IPQ40xx: Add SMEM support Robert Marko
2020-08-03 14:39 ` [PATCH 1/2] IPQ40xx: Add DRAM detection & FDT fixup Tom Rini
2020-08-04 11:20 ` Robert Marko
2020-08-04 13:44 ` Tom Rini [this message]
2020-08-07 11:35 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804134457.GY6965@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox