From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] fit_image: Use calloc() to fix reproducibility issue
Date: Wed, 5 Aug 2020 16:28:28 -0400 [thread overview]
Message-ID: <20200805202828.GI6965@bill-the-cat> (raw)
In-Reply-To: <20200728000313.31130-1-festevam@gmail.com>
On Mon, Jul 27, 2020 at 09:03:13PM -0300, Fabio Estevam wrote:
> Vagrant Cascadian reported that mx6cuboxi target no longer builds
> reproducibility on Debian.
>
> One example of builds mismatches:
>
> 00096680: 696e 6700 736f 756e 642d 6461 6900 6465 ing.sound-dai.de
> -00096690: 7465 6374 2d67 7069 6f73 0000 tect-gpios..
> +00096690: 7465 6374 2d67 7069 6f73 0061 tect-gpios.a
>
> This problem happens because all the buffers in fit_image.c are
> allocated via malloc(), which does not zero out the allocated buffer.
>
> Using calloc() fixes this unpredictable behaviour as it guarantees
> that the allocated buffer are zero initialized.
>
> Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
> Suggested-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200805/84aaaa32/attachment.sig>
prev parent reply other threads:[~2020-08-05 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 0:03 [PATCH v2] fit_image: Use calloc() to fix reproducibility issue Fabio Estevam
2020-07-28 19:07 ` Vagrant Cascadian
2020-08-05 20:28 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805202828.GI6965@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox