From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v5 06/11] gpio: dw: Add a trailing underscore to generated name
Date: Sat, 15 Aug 2020 11:52:32 -0400 [thread overview]
Message-ID: <20200815155237.467720-7-seanga2@gmail.com> (raw)
In-Reply-To: <20200815155237.467720-1-seanga2@gmail.com>
Previously, if there was no bank-name property, it was easy to have
confusing gpio names like "gpio1 at 08", instead of "gpio1 at 0_8". This patch
follows the example of the sifive gpio driver.
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
This patch was previously submitted as part of
https://patchwork.ozlabs.org/project/uboot/list/?series=161576
(no changes since v1)
drivers/gpio/dwapb_gpio.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c
index bf324f5239..a52c9e18e3 100644
--- a/drivers/gpio/dwapb_gpio.c
+++ b/drivers/gpio/dwapb_gpio.c
@@ -186,7 +186,15 @@ static int gpio_dwapb_bind(struct udevice *dev)
* Fall back to node name. This means accessing pins
* via bank name won't work.
*/
- plat->name = ofnode_get_name(node);
+ char name[32];
+
+ snprintf(name, sizeof(name), "%s_",
+ ofnode_get_name(node));
+ plat->name = strdup(name);
+ if (!plat->name) {
+ kfree(plat);
+ return -ENOMEM;
+ }
}
ret = device_bind_ofnode(dev, dev->driver, plat->name,
--
2.28.0
next prev parent reply other threads:[~2020-08-15 15:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 15:52 [PATCH v5 00/11] riscv: Add FPIOA and GPIO support for Kendryte K210 Sean Anderson
2020-08-15 15:52 ` [PATCH v5 01/11] pinctrl: Add pinmux property support to pinctrl-generic Sean Anderson
2020-08-15 15:52 ` [PATCH v5 02/11] pinctrl: Reformat documentation in dm/pinctrl.h Sean Anderson
2020-09-02 12:26 ` Heinrich Schuchardt
2020-09-02 14:56 ` Sean Anderson
2020-09-02 15:17 ` Heinrich Schuchardt
2020-09-02 15:38 ` Sean Anderson
2020-08-15 15:52 ` [PATCH v5 03/11] test: pinmux: Add test for pin muxing Sean Anderson
2020-08-15 15:52 ` [PATCH v5 04/11] pinctrl: Add support for Kendryte K210 FPIOA Sean Anderson
2020-08-15 15:52 ` [PATCH v5 05/11] gpio: dw: Fix warnings about casting int to pointer Sean Anderson
2020-08-15 15:52 ` Sean Anderson [this message]
2020-08-15 15:52 ` [PATCH v5 07/11] gpio: dw: Return output value when direction is out Sean Anderson
2020-08-15 15:52 ` [PATCH v5 08/11] led: gpio: Default to using node name if label is absent Sean Anderson
2020-08-15 15:52 ` [PATCH v5 09/11] test: dm: Test for default led naming Sean Anderson
2020-08-15 15:52 ` [PATCH v5 10/11] riscv: Add pinmux and gpio bindings for Kendryte K210 Sean Anderson
2020-09-02 18:04 ` Heinrich Schuchardt
2020-09-02 20:43 ` Sean Anderson
2020-08-15 15:52 ` [PATCH v5 11/11] riscv: Add FPIOA and GPIO support " Sean Anderson
2020-08-19 3:48 ` Rick Chen
2020-08-19 11:12 ` Sean Anderson
2020-08-20 8:07 ` Rick Chen
2020-08-20 8:47 ` Rick Chen
2020-08-31 21:48 ` Sean Anderson
2020-09-01 1:19 ` Rick Chen
2020-09-02 12:26 ` Heinrich Schuchardt
2020-09-02 15:59 ` Sean Anderson
2020-09-05 14:40 ` Sean Anderson
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA473754A@ATCPCS16.andestech.com>
2020-08-21 9:08 ` Ruinland ChuanTzu Tsai
2020-08-21 10:06 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200815155237.467720-7-seanga2@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox