From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 3/7] f_sdp: Fix wrong usb request size
Date: Tue, 18 Aug 2020 13:24:13 +0200 [thread overview]
Message-ID: <20200818132413.3ce35e57@jawa> (raw)
In-Reply-To: <20200818101649.16509-4-peng.fan@nxp.com>
On Tue, 18 Aug 2020 18:16:45 +0800
Peng Fan <peng.fan@nxp.com> wrote:
> From: Ye Li <ye.li@nxp.com>
>
> Because the buffer length of sdp usb request is 65, we have to
> allocate 65 bytes not 64 bytes. Otherwise there is potential buffer
> overflow.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/usb/gadget/f_sdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
> index f971ccdeca..eec7560fc2 100644
> --- a/drivers/usb/gadget/f_sdp.c
> +++ b/drivers/usb/gadget/f_sdp.c
> @@ -548,7 +548,7 @@ static struct usb_request *sdp_start_ep(struct
> usb_ep *ep) {
> struct usb_request *req;
>
> - req = alloc_ep_req(ep, 64);
> + req = alloc_ep_req(ep, 65);
> debug("%s: ep:%p req:%p\n", __func__, ep, req);
>
> if (!req)
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200818/8ededa38/attachment.sig>
next prev parent reply other threads:[~2020-08-18 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 10:16 [PATCH v2 0/7] f_sdp: fix and update Peng Fan
2020-08-18 10:16 ` [PATCH v2 1/7] sdp: call board_usb_init at spl_sdp_load_image Peng Fan
2020-08-18 11:22 ` Lukasz Majewski
2020-08-18 12:31 ` Peng Fan
2020-08-18 10:16 ` [PATCH v2 2/7] f_sdp: Add high speed endpoint descriptor Peng Fan
2020-08-18 11:23 ` Lukasz Majewski
2020-08-18 10:16 ` [PATCH v2 3/7] f_sdp: Fix wrong usb request size Peng Fan
2020-08-18 11:24 ` Lukasz Majewski [this message]
2020-08-18 10:16 ` [PATCH v2 4/7] f_sdp: Support searching and loading FIT or container image Peng Fan
2020-08-18 11:32 ` Lukasz Majewski
2020-08-18 12:38 ` Peng Fan
2020-08-18 12:42 ` Lukasz Majewski
2020-08-18 10:16 ` [PATCH v2 5/7] spl: add g_dnl_get_board_bcd_device_number Peng Fan
2020-08-18 11:32 ` Lukasz Majewski
2020-08-18 10:16 ` [PATCH v2 6/7] f_sdp: Add EP1_OUT as default data receive pipe in sdp Peng Fan
2020-08-18 10:16 ` [PATCH v2 7/7] f_sdp: Change bInterval of interrupt endpoint to 3 Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818132413.3ce35e57@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox