From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 5/9] cmd: Kconfig: Change dependency of CMD_USB_SDP
Date: Wed, 19 Aug 2020 08:37:05 -0400 [thread overview]
Message-ID: <20200819123705.GU20605@bill-the-cat> (raw)
In-Reply-To: <7690882a389d8172e484a22c737a29cf7afaa526.1597826658.git.michal.simek@xilinx.com>
On Wed, Aug 19, 2020 at 10:44:19AM +0200, Michal Simek wrote:
> USB_FUNCTION_SDP depends on USB_GADGET_DOWNLOAD to be enabled which is not
> reflect in Kconfig. Fix it by changing select to depends on for CMD_USB_SDP
> command.
> Kconfig is reporting it as:
> WARNING: unmet direct dependencies detected for USB_FUNCTION_SDP
> Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n]
> Selected by [y]:
> - CMD_USB_SDP [=y]
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> cmd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index bd3559ae6c12..f291c8cbf423 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1351,7 +1351,7 @@ config CMD_USB
>
> config CMD_USB_SDP
> bool "sdp"
> - select USB_FUNCTION_SDP
> + depends on USB_FUNCTION_SDP
> help
> Enables the command "sdp" which is used to have U-Boot emulating the
> Serial Download Protocol (SDP) via USB.
Based on usage, USB_FUNCTION_SDP looks to really be a library type
function. Adding some iMX folks as it's used there, and Lokesh since
the K2G platforms enable the library side, but I don't think use it?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/f6501d52/attachment.sig>
next prev parent reply other threads:[~2020-08-19 12:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 8:44 [PATCH 0/9] Incorrect Kconfig dependencies Michal Simek
2020-08-19 8:44 ` [PATCH 1/9] pci: kconfig: Setup proper dependency for PCIE_ROCKCHIP Michal Simek
2020-08-19 12:26 ` Tom Rini
2020-08-28 12:53 ` Tom Rini
2020-08-19 8:44 ` [PATCH 2/9] cmd: Kconfig: Add missing dependency for cmd gpt Michal Simek
2020-08-19 8:46 ` Heinrich Schuchardt
2020-08-19 8:51 ` Michal Simek
2020-08-19 9:01 ` Heinrich Schuchardt
2020-08-19 12:25 ` Tom Rini
2020-08-19 8:44 ` [PATCH 3/9] cmd: Kconfig: Change dependency for CMD_ADC Michal Simek
2020-08-19 12:29 ` Tom Rini
2020-08-28 12:53 ` Tom Rini
2020-08-19 8:44 ` [PATCH 4/9] nand: Kconfig: Change dependency for NAND_ARASAN Michal Simek
2020-08-19 12:31 ` Tom Rini
2020-08-19 12:36 ` Michal Simek
2020-08-19 12:43 ` Tom Rini
2020-08-19 12:52 ` Michal Simek
2020-08-19 13:15 ` Tom Rini
2020-08-19 13:21 ` Michal Simek
2020-09-23 12:07 ` Michal Simek
2020-08-19 8:44 ` [PATCH 5/9] cmd: Kconfig: Change dependency of CMD_USB_SDP Michal Simek
2020-08-19 12:37 ` Tom Rini [this message]
2020-08-19 8:44 ` [PATCH 6/9] arc: Kconfig: Add missing DM dependency Michal Simek
2020-08-21 23:41 ` Simon Glass
2020-08-28 12:53 ` Tom Rini
2020-08-19 8:44 ` [PATCH 7/9] ARM: zynqmp: Fix SPL_DM_SPI dependencies Michal Simek
2020-09-23 12:25 ` Michal Simek
2020-08-19 8:44 ` [PATCH 8/9] cmd: Kconfig: Fix dependencies for CMD_USB_MASS_STORAGE Michal Simek
2020-08-19 12:38 ` Tom Rini
2020-08-19 8:44 ` [PATCH 9/9] env: Kconfig: Add missing dependency for ENV_IS_IN_EXT4 Michal Simek
2020-08-19 12:28 ` Tom Rini
2020-08-28 12:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819123705.GU20605@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox