public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 6/8] mips: octeon: cache.c: Flush all pending writes in flush_dcache_range()
Date: Thu, 20 Aug 2020 07:35:41 +0200	[thread overview]
Message-ID: <20200820053543.2801672-7-sr@denx.de> (raw)
In-Reply-To: <20200820053543.2801672-1-sr@denx.de>

As noticed while working on the USB xHCI support, Octeon needs to flush
all pending writes so that the values are present in the memory. Add
this "syncw" instruction (twice) to flush_dcache_range().

Signed-off-by: Stefan Roese <sr@denx.de>
---

(no changes since v1)

 arch/mips/mach-octeon/cache.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/mips/mach-octeon/cache.c b/arch/mips/mach-octeon/cache.c
index 9a88bb97c7..f293d65dae 100644
--- a/arch/mips/mach-octeon/cache.c
+++ b/arch/mips/mach-octeon/cache.c
@@ -5,14 +5,13 @@
 
 #include <cpu_func.h>
 
-/*
- * The Octeon platform is cache coherent and cache flushes and invalidates
- * are not needed. Define some platform specific empty flush_foo()
- * functions here to overwrite the _weak common function as a no-op.
- * This effectively disables all cache operations.
- */
+/* Octeon memory write barrier */
+#define CVMX_SYNCW	asm volatile ("syncw\nsyncw\n" : : : "memory")
+
 void flush_dcache_range(ulong start_addr, ulong stop)
 {
+	/* Flush all pending writes */
+	CVMX_SYNCW;
 }
 
 void flush_cache(ulong start_addr, ulong size)
@@ -21,4 +20,5 @@ void flush_cache(ulong start_addr, ulong size)
 
 void invalidate_dcache_range(ulong start_addr, ulong stop)
 {
+	/* Don't need to do anything for OCTEON */
 }
-- 
2.28.0

  parent reply	other threads:[~2020-08-20  5:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  5:35 [PATCH v2 0/8] mips/usb: Add Octeon xHCI USB support Stefan Roese
2020-08-20  5:35 ` [PATCH v2 1/8] usb: xhci: xhci-dwc3.c: Use dev_remap_addr() instead of dev_get_addr() Stefan Roese
2020-08-20  8:38   ` Bin Meng
2020-08-20  5:35 ` [PATCH v2 2/8] usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses Stefan Roese
2020-08-20  8:58   ` Bin Meng
2020-08-20 10:22     ` Stefan Roese
2020-08-20  5:35 ` [PATCH v2 3/8] usb: xhci: octeon: Add DWC3 glue layer for Octeon Stefan Roese
2020-08-20  9:07   ` Bin Meng
2020-08-20 11:45     ` Stefan Roese
2020-08-20 13:24       ` Bin Meng
2020-08-20 13:54         ` Stefan Roese
2020-08-20  5:35 ` [PATCH v2 4/8] mips: octeon: cpu.c: Add table for selective swapping Stefan Roese
2020-08-20  5:35 ` [PATCH v2 5/8] mips: octeon: Add mangle-port.h Stefan Roese
2020-08-20  5:35 ` Stefan Roese [this message]
2020-08-20  5:35 ` [PATCH v2 7/8] mips: octeon: Add USB DT nodes Stefan Roese
2020-08-20  9:09   ` Bin Meng
2020-08-20 10:24     ` Stefan Roese
2020-08-20  5:35 ` [PATCH v2 8/8] mips: octeon: octeon_ebb7304_defconfig: Enable USB support Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820053543.2801672-7-sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox