From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 25 Aug 2020 08:50:02 -0400 Subject: [PATCH] usb: gadget: ether: Fix warnings about unused code In-Reply-To: <20200825115517.6feb9de4@jawa> References: <20200604200804.5759-1-trini@konsulko.com> <20200825115517.6feb9de4@jawa> Message-ID: <20200825125002.GK20605@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 25, 2020 at 11:55:17AM +0200, Lukasz Majewski wrote: > Hi Tom, > > > When building this with clang we see a few new warnings. There are a > > handful of structs that we declare and use only in the case of > > !defined(CONFIG_USB_ETH_CDC) && defined(CONFIG_USB_ETH_SUBSET) so > > update the guards used to match this as well as cover all members > > rather than just a few. Finally, eth_is_promisc() is only called by > > eth_start_xmit() which is under and #if 0 and immediately follows the > > function. Move the #if 0 up. > > > > Could you double check this patch and rebase it on top of newest master. > > As it is now it causes following build break: > https://travis-ci.org/github/lmajewski/u-boot-dfu/jobs/720654040 Lets just set it aside then. It was fine at the time but I've put down my experiment of building various targets with clang for now. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: