From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] fastboot: getvar: fix partition-size return value
Date: Thu, 27 Aug 2020 08:25:51 +0200 [thread overview]
Message-ID: <20200827082551.2f6da5c7@jawa> (raw)
In-Reply-To: <20200826101404.GA490156@p1g2>
Hi Gary,
> Hi Lukasz,
>
> On Wed, Aug 26, 2020 at 11:36:51AM +0200, Lukasz Majewski wrote:
> > Hi Gary,
> >
> > > Hi,
> > >
> > > Gentle ping on this patch. Hopefully Sam's email won't bounce this
> > > time.
> >
> > You couldn't have better timing than now :-)
> >
> > I'm now testing PR for Tom [1] and your original patch was causing
> > some issues (probably it was correct when it was posted, but it was
> > my fault that I'm going to pull it in now - my apologizes).
> >
> > I've fixed it [2] - please check if this fix is OK.
>
> Actually it was wrong before too, thanks for catching it!
> Reason is that I didn't build with FASTBOOT_FLASH_NAND config enabled
> which I should have done to check the second part of the change...
Ok. I've found another issue with this patch - it has some issues with
sunxi:
drivers/fastboot/fb_getvar.c: In function 'getvar_get_part_info':
+drivers/fastboot/fb_getvar.c:118:38: error: 'struct part_info' has no
member named 'blksz'
+ 118 | *size = part_info->size * part_info->blksz;
+ | ^~
+make[3]: *** [drivers/fastboot/fb_getvar.o] Error 1
The whole CI run can be found here:
https://travis-ci.org/github/lmajewski/u-boot-dfu/builds/721449368
>
> > Now I'm hunting another issues with sandbox [3]. When fixed I will
> > send the PR.
>
> Sounds good. Let me know if you need anything from me.
I think that the best solution would be if I drop this patch from
the series and send PR (after some CI testing) without it. If you
manage to fix it ASAP, then I will pull it immediately.
>
> Regards,
> Gary
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200827/52a083db/attachment.sig>
next prev parent reply other threads:[~2020-08-27 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 8:12 [PATCH] fastboot: getvar: fix partition-size return value Gary Bisson
2020-06-24 9:00 ` Gary Bisson
2020-08-26 9:01 ` Gary Bisson
2020-08-26 9:36 ` Lukasz Majewski
2020-08-26 10:14 ` Gary Bisson
2020-08-27 6:25 ` Lukasz Majewski [this message]
2020-08-27 7:46 ` Gary Bisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827082551.2f6da5c7@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox