[GIT] Pull request: u-boot-dfu (27.08.2019)

[GIT] Pull request: u-boot-dfu (27.08.2019)

[Lukasz Majewski]

Dear Marek,

Please find a set of DFU/Gadget/sdp/fastboot related fixes and
enhancements:

https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/commits/master

The git tag with detailed changes description in this PR can be found
here:

https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-27Aug2020


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200827/3f95dd86/attachment.sig>

[GIT] Pull request: u-boot-dfu (27.08.2019)

[Marek Vasut]

On 8/27/20 11:10 PM, Lukasz Majewski wrote:
> Dear Marek,

Hi,

> Please find a set of DFU/Gadget/sdp/fastboot related fixes and
> enhancements:
> 
> https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/commits/master
> 
> The git tag with detailed changes description in this PR can be found
> here:
> 
> https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-27Aug2020

Is this some new format of pull request, are we no longer using
git-request-pull ?

Also note that the UPDATE_TFTP is being actively used, why is it removed
here and this late in rc3 ? I think these patches should really be
postponed until after the release.

Can you please re-do the PR with only fixes ?

Thanks

[GIT] Pull request: u-boot-dfu (27.08.2019)

[Lukasz Majewski]

Hi Marek,

> On 8/27/20 11:10 PM, Lukasz Majewski wrote:
> > Dear Marek,  
> 
> Hi,
> 
> > Please find a set of DFU/Gadget/sdp/fastboot related fixes and
> > enhancements:
> > 
> > https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/commits/master
> > 
> > The git tag with detailed changes description in this PR can be
> > found here:
> > 
> > https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-27Aug2020
> >  
> 
> Is this some new format of pull request, are we no longer using
> git-request-pull ?

I thought that it would be more convenient to send the direct link to
gitlab, as it is easy to have access to merge tag information.

> 
> Also note that the UPDATE_TFTP is being actively used, 

From the other discussion, which was led mostly by Heinrich (CCed) it
was apparent that this was a dead code.

> why is it
> removed here and this late in rc3 ? I think these patches should
> really be postponed until after the release.
> 
> Can you please re-do the PR with only fixes ?

The only non-fix patches are:
- one which adds max3420 gadget

- sdp enhancements (which looks to be self contained).

> 
> Thanks




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200828/edcac95e/attachment-0001.sig>

[GIT] Pull request: u-boot-dfu (27.08.2019)

[Marek Vasut]

On 8/28/20 10:24 AM, Lukasz Majewski wrote:
> Hi Marek,

Hello Lukasz,

>> On 8/27/20 11:10 PM, Lukasz Majewski wrote:
>>> Dear Marek,  
>>
>> Hi,
>>
>>> Please find a set of DFU/Gadget/sdp/fastboot related fixes and
>>> enhancements:
>>>
>>> https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/commits/master
>>>
>>> The git tag with detailed changes description in this PR can be
>>> found here:
>>>
>>> https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-27Aug2020
>>>  
>>
>> Is this some new format of pull request, are we no longer using
>> git-request-pull ?
> 
> I thought that it would be more convenient to send the direct link to
> gitlab, as it is easy to have access to merge tag information.

Nope, all that is really needed is the remote and refspec , all of which
is in the git request-pull output. All I really ever do with the DFU PR
is $ git fetch u-boot-dfu ; <inspect the refspec> ; git merge <refspec>
and this operation doesn't involve booting the web browser :)

>> Also note that the UPDATE_TFTP is being actively used, 
> 
> From the other discussion, which was led mostly by Heinrich (CCed) it
> was apparent that this was a dead code.

Nope, I see it used, still.

Being able to download fitImage with various fragments of update and
apply them with single command is convenient, I would dislike to lose
that functionality. I don't think using $preboot is in any way a
replacement of this.

>> why is it
>> removed here and this late in rc3 ? I think these patches should
>> really be postponed until after the release.
>>
>> Can you please re-do the PR with only fixes ?
> 
> The only non-fix patches are:
> - one which adds max3420 gadget

This one is rather isolated.

> - sdp enhancements (which looks to be self contained).

OK

So just move the update_tftp patches to next, because they need more
discussion.

Thanks

[GIT] Pull request: u-boot-dfu (30.08.2019)

[Lukasz Majewski]

Dear Marek,

Please find a set of DFU/Gadget related fixes:

The following changes since commit
9f04a634ef331b4fc6b3e677f276156192a413c7:

  Merge branch '2020-08-27-misc-fixes' (2020-08-28 08:51:37 -0400)

are available in the Git repository at:

  git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git 

for you to fetch changes up to 7b55046329df3d14193debec34da515138335575:

  fastboot: getvar: fix partition-size return value (2020-08-30
  19:17:47 +0200)

----------------------------------------------------------------
Filip Brozovic (1):
      fastboot: Support defining raw partitions without a partition
table

Frank Li (1):
      sdp: call board_usb_init at spl_sdp_load_image

Gary Bisson (1):
      fastboot: getvar: fix partition-size return value

Heinrich Schuchardt (4):
      dfu: fix typo parameteres
      dfu: DFU_MTD depends on CMD_MTDPARTS
      configs: qemu: enable dfu testing
      dfu: fix dfu tftp on sandbox

Jassi Brar (1):
      usb: max3420: add the gadget driver

Peng Fan (2):
      f_sdp: Support searching and loading FIT or container image
      spl: add g_dnl_get_board_bcd_device_number

Roman Kovalivskyi (3):
      fastboot: Extend fastboot_set_reboot_flag with reboot reason
      fastboot: Add support for 'reboot fastboot' command
      fastboot: Add default fastboot_set_reboot_flag implementation

Sherry Sun (2):
      f_sdp: Add EP1_OUT as default data receive pipe in sdp
      f_sdp: Change bInterval of interrupt endpoint to 3

Ye Li (4):
      usb: gadget: Fix controller index in UMS
      usb: ci_udc: Add function to remove usb device
      f_sdp: Add high speed endpoint descriptor
      f_sdp: Fix wrong usb request size

yurii.pidhornyi (1):
      fastboot: Fix fastboot reboot fail by changing functions order


Merge tag data/information:

- gadget: Add code to set UMS controller index
- fastboot: Allow updating raw eMMC partitions (based on LBA offset)
- dfu: various fixes, remove UPDATE_TFTP Kconfig option, add qemu
  testing and fix sandbox DFU test
- fastboot: Add 'reboot fastboot' command
- usb: max3420: Add gadget driver (new code)
- sdp: Several enhancements - adding support for high speed
  descriptors, using ep 3
- sdp: Support searching and loading FIT or container image
- fastboot: Fix partition size return value for getvar

(Can be also found here:
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-30Aug2020)


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200830/b6a1d556/attachment.sig>

[GIT] Pull request: u-boot-dfu (30.08.2019)

[Marek Vasut]

On 8/30/20 9:42 PM, Lukasz Majewski wrote:
> Dear Marek,

Hi,

> Please find a set of DFU/Gadget related fixes:
> 
> The following changes since commit
> 9f04a634ef331b4fc6b3e677f276156192a413c7:
> 
>   Merge branch '2020-08-27-misc-fixes' (2020-08-28 08:51:37 -0400)
> 
> are available in the Git repository at:
> 
>   git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git 
> 
> for you to fetch changes up to 7b55046329df3d14193debec34da515138335575:

Pulled to u-boot-usb/master, thanks.