From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Mon, 31 Aug 2020 00:57:34 +0200 Subject: [PATCH u-boot-marvell] arm64: dts: armada-3720-espressobin: fix COMPHY nodes In-Reply-To: <24abb511-b3eb-f2c9-0306-bd5c88bd4b53@gmail.com> References: <20200819095725.17574-1-marek.behun@nic.cz> <24abb511-b3eb-f2c9-0306-bd5c88bd4b53@gmail.com> Message-ID: <20200831005734.2893a86a@nic.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 30 Aug 2020 08:38:32 +0200 Andre Heider wrote: > Hi Marek, > > On 19/08/2020 11:57, Marek Beh?n wrote: > > This commit fixes initialization of COMPHY on EspressoBin. > > > > Commit 22f418935be4 ("phy: marvell: a3700: Use comphy_mux on Armada > > 37xx.") introduced usage of comphy_mux on Armada 37xx comphy driver. > > The lanes are defined in comphy_a3700.c as described in functional > > specification, that is: > > lane 0 is SGMII1 or USB3 > > lane 1 is PCIe or SGMII0 > > lane 2 is SATA or USB3 > > > > But the DTS for EspressoBin configures PCIe on lane 0 and USB3 on > > lane 1, which is wrong in the sense of the specification and doesn't > > work with the comphy_mux code, which is 2 years now (the aardvark driver > > causes synchronous abort in U-Boot). > > I think armada-3720-db.dts requires the same fix? > > Regards, > Andre You are right. Sigh :( ....