From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Date: Mon, 31 Aug 2020 10:46:30 +0200 Subject: [PATCH 1/2] arm64: dts: armada-3720-espressobin: sync with downstream In-Reply-To: References: <20200831033408.467699-1-a.heider@gmail.com> <20200831080147.5gfdnnbiznq3bex2@pali> Message-ID: <20200831084630.5fl2sq2bum7cdmrz@pali> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 31 August 2020 10:17:07 Andre Heider wrote: > On 31/08/2020 10:01, Pali Roh?r wrote: > > On Monday 31 August 2020 05:34:07 Andre Heider wrote: > > > +/* U11 */ > > > +&sdhci1 { > > > + non-removable; > > > + bus-width = <8>; > > > + mmc-ddr-1_8v; > > > + mmc-hs400-1_8v; > > > + marvell,pad-type = "fixed-1-8v"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&mmc_pins>; > > > + status = "disabled"; > > > + > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + mmccard: mmccard at 0 { > > > + compatible = "mmc-card"; > > > + reg = <0>; > > > + }; > > > +}; > > > > Anyway, Andre, have you tested these Marvell's patches on top of U-Boot > > from master git branch? Because espressobin with eMMC is rather rare (do > > not know who has this board for testing; do you really have it?) and > > from my experience with previous patches I know that Marvell's patches > > does not always work on current upstream U-Boot. > > I haven't tested it on a espressobin emmc myself, but the node is the same > as for arch/arm/dts/armada-3720-db.dts and almost the same as for > arch/arm/dts/armada-3720-uDPU.dts. I think changes should be tested prior merged them into upstream. Untested patches can cause other hidden issues. Also as I wrote, other SD patches for EspressoBin copied+pasted from Marvell's did not worked as is applied on current upstream U-Boot. And also argument that "patch is similar as other node" is not reason to not test changed. As a first thing which I did for SD card support on EspressoBin was that I copied DTS node from Turris MOX... and on EspressoBin it did not worked. On MOX was card working fine.