public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Yangbo Lu <yangbo.lu@nxp.com>
To: u-boot@lists.denx.de
Subject: [v4, 09/11] mmc: fsl_esdhc: fix eMMC HS400 stability issue
Date: Tue,  1 Sep 2020 16:58:07 +0800	[thread overview]
Message-ID: <20200901085809.48660-10-yangbo.lu@nxp.com> (raw)
In-Reply-To: <20200901085809.48660-1-yangbo.lu@nxp.com>

There was a fix-up for eMMC HS400 stability issue in Linux.

Patch link:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
commit/?id=58d0bf843b49fa99588ac9f85178bd8dfd651b53

Description:
Currently only LX2160A eSDHC supports eMMC HS400. According to
a large number of tests, eMMC HS400 failed to work at 150MHz,
and for a few boards failed to work at 175MHz. But eMMC HS400
worked fine on 200MHz. We hadn't found the root cause but
setting eSDHC_DLLCFG0[DLL_FREQ_SEL] = 0 using slow delay chain
seemed to resovle this issue. Let's use this as fixup for now.

Introduce the fix-up in u-boot since the issue could be reproduced
in u-boot too.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
Changes for v2:
	- Added this patch.
Changes for v3:
	- None.
Changes for v4:
	- None.
---
 drivers/mmc/fsl_esdhc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index ce87416..a6092ad 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -644,7 +644,10 @@ static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode)
 		esdhc_setbits32(&regs->sdclkctl, CMD_CLK_CTL);
 		esdhc_clock_control(priv, true);
 
-		esdhc_setbits32(&regs->dllcfg0, DLL_ENABLE | DLL_FREQ_SEL);
+		if (priv->clock == 200000000)
+			esdhc_setbits32(&regs->dllcfg0, DLL_FREQ_SEL);
+
+		esdhc_setbits32(&regs->dllcfg0, DLL_ENABLE);
 		esdhc_setbits32(&regs->tbctl, HS400_WNDW_ADJUST);
 
 		esdhc_clock_control(priv, false);
-- 
2.7.4

  parent reply	other threads:[~2020-09-01  8:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200901090556epcas1p46358a60233c9465e6900ffb0819c9e62@epcas1p4.samsung.com>
2020-09-01  8:57 ` [v4, 00/11] mmc: fsl_esdhc: support eMMC HS200/HS400 modes Yangbo Lu
2020-09-01  8:57   ` [v4, 01/11] mmc: add a reinit() API Yangbo Lu
2020-09-01  8:58   ` [v4, 02/11] mmc: fsl_esdhc: add a reinit() callback Yangbo Lu
2020-09-01  8:58   ` [v4, 03/11] mmc: fsl_esdhc: support tuning for eMMC HS200 Yangbo Lu
2020-09-01  8:58   ` [v4, 04/11] mmc: fsl_esdhc: clean TBCTL[TB_EN] manually during init Yangbo Lu
2020-09-01  8:58   ` [v4, 05/11] mmc: add a hs400_tuning flag Yangbo Lu
2020-09-01  8:58   ` [v4, 06/11] mmc: add a mmc_hs400_prepare_ddr() interface Yangbo Lu
2020-09-01  8:58   ` [v4, 07/11] mmc: fsl_esdhc: support eMMC HS400 mode Yangbo Lu
2020-09-01  8:58   ` [v4, 08/11] mmc: fsl_esdhc: fix mmc->clock with actual clock Yangbo Lu
2020-09-01  8:58   ` Yangbo Lu [this message]
2020-09-01  8:58   ` [v4, 10/11] arm: dts: lx2160ardb: support eMMC HS400 mode Yangbo Lu
2020-09-01  8:58   ` [v4, 11/11] configs: lx2160ardb: enable eMMC HS400 mode support Yangbo Lu
2020-09-07  3:19   ` [v4, 00/11] mmc: fsl_esdhc: support eMMC HS200/HS400 modes Y.b. Lu
2020-09-07  7:21     ` Jaehoon Chung
2020-09-08  1:08     ` Peng Fan
2020-09-08  7:17       ` Stefan Roese
2020-09-10  5:50   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901085809.48660-10-yangbo.lu@nxp.com \
    --to=yangbo.lu@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox