From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 7 Sep 2020 09:12:33 -0400 Subject: [PATCH v3 2/2] armv8: lx2162aqds: Add support for LX2162AQDS platform In-Reply-To: <1599473527-21511-3-git-send-email-meenakshi.aggarwal@nxp.com> References: <1599126784-10976-3-git-send-email-meenakshi.aggarwal@nxp.com> <1599473527-21511-1-git-send-email-meenakshi.aggarwal@nxp.com> <1599473527-21511-3-git-send-email-meenakshi.aggarwal@nxp.com> Message-ID: <20200907131233.GN24856@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Sep 07, 2020 at 03:42:07PM +0530, meenakshi.aggarwal at nxp.com wrote: > From: Meenakshi Aggarwal > > This patch add base support for LX2162AQDS board. > LX2162AQDS board supports LX2162A family SoCs. > This patch add basic support of platform. > > Signed-off-by: Ioana Ciornei > Signed-off-by: Zhao Qiang > Signed-off-by: hui.song > Signed-off-by: Manish Tomar > Signed-off-by: Vikas Singh > Signed-off-by: Meenakshi Aggarwal > --- > arch/arm/Kconfig | 12 + > arch/arm/dts/Makefile | 6 +- > arch/arm/dts/fsl-lx2160a-qds.dts | 3 - > arch/arm/dts/fsl-lx2160a-qds.dtsi | 22 +- > arch/arm/dts/fsl-lx2162a-qds-17-x.dts | 17 + > arch/arm/dts/fsl-lx2162a-qds-18-x.dts | 17 + > arch/arm/dts/fsl-lx2162a-qds-20-x.dts | 17 + > arch/arm/dts/fsl-lx2162a-qds-sd1-17.dtsi | 58 ++ > arch/arm/dts/fsl-lx2162a-qds-sd1-18.dtsi | 61 ++ > arch/arm/dts/fsl-lx2162a-qds-sd1-20.dtsi | 26 + > arch/arm/dts/fsl-lx2162a-qds.dts | 34 + Most of these new dts* files are not added to MAINTAINERS entries and it would be good to do so. > board/freescale/common/vid.c | 3 +- > board/freescale/lx2160a/Kconfig | 16 + > board/freescale/lx2160a/MAINTAINERS | 10 + > board/freescale/lx2160a/Makefile | 1 + > board/freescale/lx2160a/README | 132 ++++ This README also should get updated to rST and moved. [snip] > +/* > + * Need to override existing (lx2160a) with lx2162aqds so set_board_info will > + * use proper prefix when creating full board_name (SYS_BOARD + type) > + */ > +#undef CONFIG_SYS_BOARD > +#define CONFIG_SYS_BOARD "lx2162aqds" SYS_BOARD is under Kconfig, please just fix it there. > + > +#undef CONFIG_SYS_NXP_SRDS_3 > + > +/* Qixis */ > +#define QIXIS_XMAP_MASK 0x07 This is the start of adding tons of non-CONFIG information to the config header. Don't do this, it's going to make full migration to Kconfig harder. Please audit the whole file and anything that's not CONFIG_xxx needs to be somewhere else really. Thanks. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: