From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Tue, 8 Sep 2020 01:58:01 +0200 Subject: [PATCH U-BOOT v3 03/30] fs: btrfs: Crossport btrfs_read_dev_super() from btrfs-progs In-Reply-To: <20200907222604.GA706@bill-the-cat> References: <20200624160316.5001-1-marek.behun@nic.cz> <20200624160316.5001-4-marek.behun@nic.cz> <20200907222604.GA706@bill-the-cat> Message-ID: <20200908015801.3b72869a@nic.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 7 Sep 2020 18:26:04 -0400 Tom Rini wrote: > On Wed, Jun 24, 2020 at 06:02:49PM +0200, Marek Beh?n wrote: > > > From: Qu Wenruo > > > > This patch uses generic code from btrfs-progs to read one super block > > from block device. > [snip] > > +/* Provide a compatibility layer to make code syncing easier */ > > + > > +/* A simple wraper to for error() used in btrfs-progs */ > > +__attribute__((format (__printf__, 1, 2))) > > +static inline void error(const char *fmt, ...) > > +{ > > + printf("BTRFS: "); > > + printf(fmt, __builtin_va_arg_pack()); > > + printf("\n"); > > +} > > Note that this does not work with LLVM (no __builtin_va_arg_pack()). > I'm reworking this call pr_err(...) under the hood instead, with "BTRFS: " > included in the message. > :( clang does not support it? Even the newest version? That is a pity. Marek