From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] mx6qsabrelite: increase offset for environment on SPI
Date: Mon, 14 Sep 2020 08:33:18 -0400 [thread overview]
Message-ID: <20200914123318.GF5110@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5B8=p7Snhss7g2KFRWP_KoSthQYfN419fSVt75mtysy7Q@mail.gmail.com>
On Mon, Sep 14, 2020 at 08:03:33AM -0300, Fabio Estevam wrote:
> Hi Denis,
>
> On Mon, Sep 14, 2020 at 6:56 AM Denis Pynkin <denis.pynkin@collabora.com> wrote:
> >
> > The size of the binary created with the default U-boot config is much
> > greater than the default offset for environment `0x60000`. If the new
> > version is flashed onto SPI it overlaps with the stored environment.
> > This leads to U-Boot corruption in case of saving environment onto
> > SPI and non-bootable SabreLite board.
> >
> > Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> In case you want to detect errors like this again in the future, you could add
> CONFIG_BOARD_SIZE_LIMIT that detects such overlaps in build-time.
>
> Please check commit 033f6ea5fa5f ("mx53loco: Fix U-Boot corruption
> after saving the environment")
>
> The addition of CONFIG_BOARD_SIZE_LIMIT can be a separate patch though.
Hold on. Can we shrink the board back down so that we don't need to
move the environment? Moving the environment is bad as it will also
break existing users. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200914/76207c23/attachment.sig>
next prev parent reply other threads:[~2020-09-14 12:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 9:56 [PATCH] mx6qsabrelite: increase offset for environment on SPI Denis Pynkin
2020-09-14 10:01 ` Stefano Babic
2020-09-14 11:03 ` Fabio Estevam
2020-09-14 12:33 ` Tom Rini [this message]
2020-09-14 13:20 ` Denis Pynkin
2020-09-14 13:29 ` Tom Rini
2020-09-14 14:11 ` Tom Rini
2020-09-14 17:08 ` Denis Pynkin
2020-09-14 18:50 ` Tom Rini
2020-09-14 19:48 ` Denis Pynkin
2020-09-15 11:37 ` [PATCH v2] mx6qsabrelite: increase the environment offset Denis Pynkin
2020-09-15 12:49 ` Tom Rini
2020-09-18 14:06 ` sbabic at denx.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914123318.GF5110@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox