[PATCH 1/5] sunxi: video: No double clock on DE2

Maxime Ripard
2020-09-16T14:48:24Z

On Wed, Sep 16, 2020 at 04:10:48PM +0200, Martin Cerveny wrote:
> Weird code or comment. This is variant is tested on V3s.
>
> Signed-off-by: Martin Cerveny <m.cerveny@computer.org>

Generally speaking your commit logs are fairly concise, but it really
becomes an issue when you're allegedly fixing a bug.

There's a bunch of questions here that are completely up in the air:

- What issue are you actually trying to fix, how can one reproduce it
- You claim that there's no double clock on the DE2, according to
what?
- DE2 is used on way more SoCs than just the V3s, did you check/test
on those SoCs as well?

In general, a good commit log should not explain what you're doing but
*why* you're doing it. The what can be quite easily figured out from the
patch content, the why can't today, and it will be even harder in a
year's time.

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200916/57638848/attachment.sig>