From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 1/1] sandbox: redefine getc()
Date: Tue, 29 Sep 2020 14:50:04 -0400 [thread overview]
Message-ID: <20200929185004.GO14816@bill-the-cat> (raw)
In-Reply-To: <20200929184312.44941-1-xypron.glpk@gmx.de>
On Tue, Sep 29, 2020 at 08:43:12PM +0200, Heinrich Schuchardt wrote:
> The sandbox is built with the SDL2 library with invokes the X11 library
> which in turn calls getc(). But getc() in glibc is defined as
>
> int getc(FILE *)
>
> This does not match our definition.
>
> int getc(void)
>
> The sandbox crashes when called with parameter -l.
>
> Rename our library symbol to be called _u_boot_getc(). To keep the coding
> changes minimal use a define on the sandbox only.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> v2:
> apply changes only to the sandbox
Wolfgang, I was wondering could we not, given the few callers of 'getc'
carefully change our internal usage / name to 'getchar', which is more
POSIX-like and have our EXPORT_FUNC line be:
EXPORT_FUNC(getc, int, getchar, void)
and that might be the clean solution here?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200929/2b60e470/attachment.sig>
next prev parent reply other threads:[~2020-09-29 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 18:43 [PATCH v2 1/1] sandbox: redefine getc() Heinrich Schuchardt
2020-09-29 18:50 ` Tom Rini [this message]
2020-09-30 11:49 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929185004.GO14816@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox