From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 14/16] usb: musb-new: mt85xx: Fix not calling dev_err with a device
Date: Sun, 4 Oct 2020 21:39:55 -0400 [thread overview]
Message-ID: <20201005013958.498888-15-seanga2@gmail.com> (raw)
In-Reply-To: <20201005013958.498888-1-seanga2@gmail.com>
This driver doesn't use DM (in the correct places), so we use a device and
not a udevice. We also need to include device_compat.h
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
drivers/usb/musb-new/mt85xx.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/musb-new/mt85xx.c b/drivers/usb/musb-new/mt85xx.c
index c281c38a28..8f0561eeba 100644
--- a/drivers/usb/musb-new/mt85xx.c
+++ b/drivers/usb/musb-new/mt85xx.c
@@ -12,6 +12,7 @@
#include <common.h>
#include <clk.h>
#include <dm.h>
+#include <dm/device_compat.h>
#include <dm/lists.h>
#include <dm/root.h>
#include <linux/delay.h>
@@ -244,17 +245,17 @@ static int mtk_musb_init(struct musb *musb)
ret = clk_enable(&glue->usbpllclk);
if (ret) {
- dev_err(dev, "failed to enable usbpll clock\n");
+ dev_err(musb->controller, "failed to enable usbpll clock\n");
return ret;
}
ret = clk_enable(&glue->usbmcuclk);
if (ret) {
- dev_err(dev, "failed to enable usbmcu clock\n");
+ dev_err(musb->controller, "failed to enable usbmcu clock\n");
return ret;
}
ret = clk_enable(&glue->usbclk);
if (ret) {
- dev_err(dev, "failed to enable usb clock\n");
+ dev_err(musb->controller, "failed to enable usb clock\n");
return ret;
}
--
2.28.0
next prev parent reply other threads:[~2020-10-05 1:39 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 1:39 [PATCH 00/16] dm: Remove redefinitions of dev_xxx macros Sean Anderson
2020-10-05 1:39 ` [PATCH 01/16] clk: sifive: Include device_compat.h Sean Anderson
2020-10-16 13:54 ` Tom Rini
2020-10-05 1:39 ` [PATCH 02/16] dm: syscon: Set LOG_CATEGORY Sean Anderson
2020-10-12 3:34 ` Simon Glass
2020-10-16 13:54 ` Tom Rini
2020-10-05 1:39 ` [PATCH 03/16] firmware: scmi: Include device_compat.h Sean Anderson
2020-10-12 3:34 ` Simon Glass
2020-10-16 13:54 ` Tom Rini
2020-10-05 1:39 ` [PATCH 04/16] mtd: mxs_nand: Fix not calling dev_xxx with a device Sean Anderson
2020-10-16 13:54 ` Tom Rini
2020-10-05 1:39 ` [PATCH 05/16] net: ldpaa_eth: Include device_compat.h Sean Anderson
2020-10-16 13:54 ` Tom Rini
2020-10-05 1:39 ` [PATCH 06/16] phy: " Sean Anderson
2020-10-16 13:54 ` Tom Rini
2020-10-05 1:39 ` [PATCH 07/16] ram: imxrt: " Sean Anderson
2020-10-16 13:54 ` Tom Rini
2020-10-05 1:39 ` [PATCH 08/16] spi: nsp_fspi: " Sean Anderson
2020-10-05 10:07 ` [EXT] " Kuldeep Singh
2020-10-16 13:55 ` [PATCH 08/16] spi: nxp_fspi: " Tom Rini
2020-10-05 1:39 ` [PATCH 09/16] spi: fsl_qspi: " Sean Anderson
2020-10-16 13:55 ` Tom Rini
2020-10-05 1:39 ` [PATCH 10/16] tee: optee: " Sean Anderson
2020-10-12 3:34 ` Simon Glass
2020-10-16 13:55 ` Tom Rini
2020-10-16 14:10 ` Igor Opaniuk
2020-10-05 1:39 ` [PATCH 11/16] timer: " Sean Anderson
2020-10-12 3:34 ` Simon Glass
2020-10-16 13:55 ` Tom Rini
2020-10-05 1:39 ` [PATCH 12/16] usb: xhci: " Sean Anderson
2020-10-16 13:55 ` Tom Rini
2020-10-05 1:39 ` [PATCH 13/16] usb: musb-new: " Sean Anderson
2020-10-16 13:55 ` Tom Rini
2020-10-05 1:39 ` Sean Anderson [this message]
2020-10-16 13:55 ` [PATCH 14/16] usb: musb-new: mt85xx: Fix not calling dev_err with a device Tom Rini
2020-10-05 1:39 ` [PATCH 15/16] linux/compat.h: Remove redefinition of dev_xxx macros Sean Anderson
2020-10-12 3:34 ` Simon Glass
2020-10-16 13:56 ` Tom Rini
2020-10-05 1:39 ` [PATCH 16/16] dm: Don't undefine " Sean Anderson
2020-10-12 3:34 ` Simon Glass
2020-10-16 13:56 ` Tom Rini
2020-10-16 12:42 ` [PATCH 1/3] arm: fsl-layerscape: Include device_compat.h in soc.c Tom Rini
2020-10-16 12:42 ` [PATCH 2/3] clk: at91: Include device_compat.h in compat.c Tom Rini
2020-10-16 13:56 ` Tom Rini
2020-10-16 12:42 ` [PATCH 3/3] usb: dwc3: Include device_compat.h in dwc3-octeon-glue.c Tom Rini
2020-10-16 13:56 ` Tom Rini
2020-10-16 13:56 ` [PATCH 1/3] arm: fsl-layerscape: Include device_compat.h in soc.c Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005013958.498888-15-seanga2@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox